Fix hosts key in Elastic 8 configuration
#547
Merged
+15
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HypeMC
approved these changes
Oct 17, 2025
GromNaN
added a commit
that referenced
this pull request
Oct 17, 2025
This PR was merged into the 3.x branch. Discussion ---------- Fix 'hosts' key in Elastica 8 configuration | Q | A | ------------- | --- | Branch? | 3.x | Bug fix? | yes | New feature? | yes | Deprecations? | no | Issues | Fix #499 | License | MIT Backport #547 that was merged into 4.x instead of 3.x. Adding tests. Commits ------- 2a6d971 Fix 'hosts' key in Elastic 8 configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elastica 8+ client has an option
hostsinstead ofhost(ruflin/Elastica#2188).Adding a new
monolog.handlers.(elastica|elastic_search).elasticsearch.hostssetting that is a list of strings.This way, we don't try to detect which version of elastica is used, an let the developers set the correct configuration depending on the version they have installed.