Skip to content

Fix build, align with more modern JavaScriptKit #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
yonihemi wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix build, align with more modern JavaScriptKit #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ let package = Package(
dependencies: [
.package(
url: "https://github.com/swiftwasm/JavaScriptKit.git",
.upToNextMajor(from: "0.16.0")
from: "0.19.0"
),
],
targets: [
Expand Down
1 change: 1 addition & 0 deletions Sources/WebFoundation/URLSession.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import Foundation
import JavaScriptEventLoop
import JavaScriptKit

@available(macOS 14.0, iOS 17.0, watchOS 10.0, tvOS 17.0, *)
public class URLSession {
public static let shared = URLSession()

Expand Down
5 changes: 4 additions & 1 deletion Sources/WebFoundation/Upstream/URLRequest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,10 @@ public struct URLRequest: Equatable, Hashable {
public var httpBody: Data?

@available(*, unavailable, message: "httpBodyStream is not yet available in WebFoundation")
public var httpBodyStream: Any?
public var httpBodyStream: Any? {
get { nil }
set { }
}

/// `true` if cookies will be sent with and set for this request; otherwise `false`.
public var httpShouldHandleCookies = true
Expand Down