Exclude expected completions in a couple of places #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
force-pushed
the
exclude-completions
branch
from
706087a to
293308e
Compare
Contributor
Author
|
Stress tester ran on swiftlang/swift#58827 |
ahoppen
reviewed
Nov 24, 2025
SourceKitStressTester/Sources/StressTester/ActionGenerators.swift
Outdated
Show resolved
Hide resolved
Comment on lines
+729
to
+731
| // FIXME: We ought to have this be configurable and enable it for the stress | ||
| // tester. |
Member
There was a problem hiding this comment.
Do you remember how the compiler skips these. IIRC it’s looking for #file or #line default argument values. Which unfortunately we can’t do here, so maybe this is fine.
Contributor
Author
There was a problem hiding this comment.
Yeah it's done here, IMO it would be nice to have a mode where it still includes them just for the stress tester since we otherwise can't handle them properly in the general case. #file and #line were the only ones that the new revision of swift-power-assert ran into though
Member
There was a problem hiding this comment.
We could add a sourcekitd option for it, I wouldn’t have any objections to it.
SourceKitStressTester/Sources/StressTester/SourceKitDocument.swift
Outdated
Show resolved
Hide resolved
We don't provide default argument completions for `#file` and `#line`, for now let's skip matching `file` and `line` as argument labels.
Don't check completions for e.g `@_spi` or its arguments.
hamishknight
force-pushed
the
exclude-completions
branch
from
293308e to
1548bf0
Compare
Contributor
Author
|
@swift-ci please test |
ahoppen
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid matching expected completions for underscored attributes and skip matching
fileandlineas argument labels since we skip#fileand#linedefault args for completion. This is necessary to fix the stress tester for the recently updated revision of swift-power-assert.