-
Notifications
You must be signed in to change notification settings - Fork 253
Remove old prerelease caveats from cloud packages page #1252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
timsneath
wants to merge
1
commit into
swiftlang:main
Choose a base branch
from
timsneath:timsneath-server
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swift OPA still is pre-1.0: https://github.com/open-policy-agent/swift-opa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, interesting. I know you're authoritative :) but I couldn't find any reference to it being still a pre-release.
In any event, I wonder if this really is the place to track its status -- any of the above URLs would probably a better place to describe its status, since they're the places that will get updated with a change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project being pre-1.0 just means it doesn't have a stable API yet, so packages can't depend on it expecting a stable API for a few years.
Swift OPA doesn't appear to have any releases yet (https://github.com/open-policy-agent/swift-opa/releases), so the only way to depend on it would be
branch: "main"which would prevent your package from being even tagged with a version, I believe (SwiftPM would reject it).I think of production readiness as an orthogonal metric, some packages are solid even before 1.0, others need time to bake post-1.0. But our original note about the lack of 1.0 was to call out the lack of a stable API yet.
Whether we want to keep it I'm agnostic about, fine either way.