Use unicode literals to clarify that 3 different characters are added to the CharacterSet #1380
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
d-ronnqvist
force-pushed
the
use-unicode-literals-in-character-set
branch
from
02c77a3 to
4ce641b
Compare
Contributor
Author
|
@swift-ci please test |
heckj
approved these changes
Dec 5, 2025
patshaughnessy
approved these changes
Dec 6, 2025
| .subtracting(CharacterSet(charactersIn: "-")) // Don't remove hyphens. They are used as a whitespace replacement. | ||
| static let whitespaceAndDashes = CharacterSet.whitespaces | ||
| .union(CharacterSet(charactersIn: "-–—")) // hyphen, en dash, em dash | ||
| .union(CharacterSet(charactersIn: "-\u{2013}\u{2014}")) // hyphen, en dash, em dash |
Contributor
There was a problem hiding this comment.
Much better thank you. Previously it was impossible to tell what was going on here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable:
Summary
This is a follow up from #1369
It clarifies some new and existing code based on PR feedback.
Dependencies
None.
Testing
Nothing in particular. This isn't a user facing change.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
[ ] Added tests./bin/testscript and it succeeded[ ] Updated documentation if necessary