Refactor: Improve test coverage on MainActivityViewModel

app/build.gradle.kts

@@ -1,5 +1,6 @@
 import java.io.FileInputStream
-import java.util.*
+import java.util.Base64
+import java.util.Properties
 
 plugins {
     id("com.android.application")
@@ -110,6 +111,35 @@ tasks.register<JacocoReport>("jacocoTestReport") {
         csv.required.set(false)
     }
 
+    val fileFilter = listOf(
+        "**/R.class",
+        "**/MainActivity.*",
+        "**/R$*.class", "**/BuildConfig.*", "**/Manifest*.*",
+        "**/*Test*.*", "android/**/*.*",
+        "**/Dagger*.*", "**/*_Hilt*.*", "**/*Hilt*.*",
+    )
+    val kotlinDebugTree = fileTree(layout.buildDirectory.dir("tmp/kotlin-classes/debug")) { exclude(fileFilter) }
+    val mainKotlinSrc = layout.projectDirectory.dir("src/main/kotlin")
+    sourceDirectories.from(files(mainKotlinSrc))
+    classDirectories.from(files(kotlinDebugTree))
+    executionData.from(fileTree(layout.buildDirectory) {
+        include(
+            "outputs/managed_device_code_coverage/**/*.ec",
+            "outputs/unit_test_code_coverage/**/*.exec",
+        )
+    })
+}
+
+tasks.register<JacocoReport>("jacocoUiOnly") {
+
+    dependsOn("pixel2api30DebugAndroidTest")
+
+    reports {
+        xml.required.set(true)
+        html.required.set(true)
+        csv.required.set(false)
+    }
+
     val fileFilter = listOf(
         "**/R.class", "**/R$*.class", "**/BuildConfig.*", "**/Manifest*.*",
         "**/*Test*.*", "android/**/*.*",
@@ -123,7 +153,6 @@ tasks.register<JacocoReport>("jacocoTestReport") {
     classDirectories.from(files(javaDebugTree, kotlinDebugTree))
     executionData.from(fileTree(layout.buildDirectory) {
         include(
-            "outputs/unit_test_code_coverage/**/*.exec",
             "outputs/managed_device_code_coverage/**/*.ec",
             "outputs/managed_device_code_coverage/**/*.exec"
         )

app/src/androidTest/java/org/kabiri/android/usbterminal/MainActivityAndroidTest.kt

@@ -15,17 +15,15 @@ import org.junit.Rule
 import org.junit.Test
 import org.junit.runner.RunWith
 
-
 @RunWith(AndroidJUnit4::class)
 internal class MainActivityAndroidTest {
-
     @get:Rule
     var rule = activityScenarioRule<MainActivity>()
 
     private fun ensureMenuIsAccessible(
         menuItemId: Int,
         onVisible: () -> Unit,
-        onOverflow: () -> Unit
+        onOverflow: () -> Unit,
     ) {
         try {
             // Try to find the menu item first
@@ -49,57 +47,53 @@ internal class MainActivityAndroidTest {
     }
 
     @Test
-    fun checkActionMenuItemSettingsIsDisplayed() = ensureMenuIsAccessible(
-        menuItemId = R.id.actionSettings,
-        onVisible = {
-
-            // assert
-            onView(withId(R.id.actionSettings)).check(matches(isDisplayed()))
-        },
-        onOverflow = {
-
-            // assert
-            onView(withText(R.string.title_settings)).check(matches(isDisplayed()))
-        }
-    )
+    fun checkActionMenuItemSettingsIsDisplayed() =
+        ensureMenuIsAccessible(
+            menuItemId = R.id.actionSettings,
+            onVisible = {
+                // assert
+                onView(withId(R.id.actionSettings)).check(matches(isDisplayed()))
+            },
+            onOverflow = {
+                // assert
+                onView(withText(R.string.title_settings)).check(matches(isDisplayed()))
+            },
+        )
 
     @Test
-    fun checkActionMenuItemConnectIsDisplayed() = ensureMenuIsAccessible(
-        menuItemId = R.id.actionSettings,
-        onVisible = {
-
-            // assert
-            onView(withId(R.id.actionConnect)).check(matches(isDisplayed()))
-        },
-        onOverflow = {
-
-            // assert
-            onView(withText(R.string.title_connect)).check(matches(isDisplayed()))
-        }
-    )
+    fun checkActionMenuItemConnectIsDisplayed() =
+        ensureMenuIsAccessible(
+            menuItemId = R.id.actionSettings,
+            onVisible = {
+                // assert
+                onView(withId(R.id.actionConnect)).check(matches(isDisplayed()))
+            },
+            onOverflow = {
+                // assert
+                onView(withText(R.string.title_connect)).check(matches(isDisplayed()))
+            },
+        )
 
     @Test
-    fun checkActionMenuItemDisconnectIsDisplayed() = ensureMenuIsAccessible(
-        menuItemId = R.id.actionSettings,
-        onVisible = {
-
-            // assert
-            onView(withId(R.id.actionDisconnect)).check(matches(isDisplayed()))
-        },
-        onOverflow = {
-
-            // assert
-            onView(withText(R.string.title_disconnect)).check(matches(isDisplayed()))
-        }
-    )
+    fun checkActionMenuItemDisconnectIsDisplayed() =
+        ensureMenuIsAccessible(
+            menuItemId = R.id.actionSettings,
+            onVisible = {
+                // assert
+                onView(withId(R.id.actionDisconnect)).check(matches(isDisplayed()))
+            },
+            onOverflow = {
+                // assert
+                onView(withText(R.string.title_disconnect)).check(matches(isDisplayed()))
+            },
+        )
 
     @Test
     fun clickingSettingsOpensSettingsBottomSheet() {
         // arrange
         ensureMenuIsAccessible(
             menuItemId = R.id.actionSettings,
             onVisible = {
-
                 // act
                 onView(withId(R.id.actionSettings)).perform(click())
 
@@ -112,7 +106,7 @@ internal class MainActivityAndroidTest {
 
                 // assert
                 onView(withId(R.id.composeViewSettingContent)).check(matches(isDisplayed()))
-            }
+            },
         )
     }
 }

app/src/main/java/org/kabiri/android/usbterminal/MainActivity.kt

@@ -19,23 +19,21 @@ import androidx.core.view.WindowInsetsCompat
 import androidx.lifecycle.lifecycleScope
 import dagger.hilt.android.AndroidEntryPoint
 import kotlinx.coroutines.launch
-import org.kabiri.android.usbterminal.util.scrollToLastLine
 import org.kabiri.android.usbterminal.ui.setting.SettingModalBottomSheet
 import org.kabiri.android.usbterminal.ui.setting.SettingViewModel
+import org.kabiri.android.usbterminal.util.scrollToLastLine
 import org.kabiri.android.usbterminal.viewmodel.MainActivityViewModel
 
+private const val TAG = "MainActivity"
+
 @AndroidEntryPoint
 class MainActivity : AppCompatActivity() {
-
-    companion object {
-        private const val TAG = "MainActivity"
-    }
-
     private val viewModel by viewModels<MainActivityViewModel>()
     private val settingViewModel by viewModels<SettingViewModel>()
 
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
+        viewModel.startObservingUsbDevice()
         setContentView(R.layout.activity_main)
 
         // avoid system navbar or soft keyboard overlapping the content.
@@ -67,9 +65,11 @@ class MainActivity : AppCompatActivity() {
         fun sendCommand() {
             val input = etInput.text.toString()
             // append the input to console
-            if (viewModel.serialWrite(input))
-                etInput.setText("") // clear the terminal input.
-            else Log.e(TAG, "The message was not sent to Arduino")
+            if (viewModel.serialWrite(input)) {
+                etInput.setText("")
+            } else {
+                Log.e(TAG, "The message was not sent to Arduino")
+            }
         }
 
         // send the command to device when the button is clicked.
@@ -83,7 +83,9 @@ class MainActivity : AppCompatActivity() {
                         event.action == KeyEvent.ACTION_DOWN)) {
                 sendCommand()
                 true
-            } else false
+            } else {
+                false
+            }
         }
     }