chore(splinter): integrate runtime #620
Merged
+2,928
−2,879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteinroe
changed the title
psteinroe
force-pushed
the
chore/integrate-splinter-runtime
branch
from
9612b64 to
9f4643c
Compare
psteinroe
force-pushed
the
chore/integrate-splinter-into-codegen
branch
from
f1f3eb0 to
67c3a79
Compare
psteinroe
force-pushed
the
chore/integrate-splinter-runtime
branch
from
9f4643c to
75f57f2
Compare
Changed pgls_analyse::AnalyserRules to pgls_analyser::LinterRules and fixed import statements to use the correct crate for RuleOptions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
psteinroe
force-pushed
the
chore/integrate-splinter-into-codegen
branch
from
67c3a79 to
d6a616c
Compare
psteinroe
force-pushed
the
chore/integrate-splinter-runtime
branch
from
75f57f2 to
c9e5c4d
Compare
Updated test files to use the new type names after the refactor: - Changed AnalyserOptions to LinterOptions - Changed RuleDiagnostic to LinterDiagnostic - Fixed import paths to import from pgls_analyser instead of pgls_analyse 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Fixed import ordering and line length formatting issues. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Picked up test import fixes from base branch and applied codegen updates. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
psteinroe
force-pushed
the
chore/integrate-splinter-into-codegen
branch
from
d6a616c to
0379759
Compare
psteinroe
force-pushed
the
chore/integrate-splinter-runtime
branch
from
c9e5c4d to
6d06773
Compare
Changed SQL file path generation to use relative paths from crate root instead of absolute paths, fixing CI codegen check failures. Also removed unused splinter/unknown category from TypeScript types. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Removed unused `use pgls_analyse::RuleMeta;` import from generated splinter rule files and applied clippy format! macro fix. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
psteinroe
force-pushed
the
chore/integrate-splinter-runtime
branch
from
6d06773 to
f1d2862
Compare
psteinroe
force-pushed
the
chore/integrate-splinter-runtime
branch
from
f1d2862 to
a61dce9
Compare
Fixed stale module reference after rebase. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
psteinroe
force-pushed
the
chore/integrate-splinter-runtime
branch
from
a61dce9 to
13afe90
Compare
Remove unnecessary SELECT * FROM wrapping that was causing syntax errors with CTEs. SQL files are already complete parenthesized queries. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Some SQL files are already wrapped in parentheses while others are not. Ensure consistent wrapping to create valid UNION ALL syntax. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
SQL files use "name!" notation for column names (literal identifiers), so FromRow must look for these exact names. Also fix clippy warnings. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Individual SQL queries' ORDER BY clauses are not preserved when combined with UNION ALL. Wrap the entire result in SELECT and ORDER BY cache_key! to ensure consistent, deterministic ordering for tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove backslash escaping from backticks in message text - Update diagnostic ordering to match cache_key sort order 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Apply automatic clippy fixes for format! macro usage 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
juleswritescode
approved these changes
Dec 16, 2025
| /// | ||
| /// ## Remediation | ||
| /// | ||
| /// See: <{remediation}>"#, |
Collaborator
There was a problem hiding this comment.
die remediation ist jetzt quasi eine remediationUrl, wir könnten auch die metadata zu "See " ändern?
wires up splinter with the docs codegen. we collect the metadata using `RuleVisitor` and print them out to markdown. This is the same approach we use with the rules from `analyser` (to be renamed to `linter`). Added the additional metadata to `SplinterRule`. --------- Co-authored-by: Claude <noreply@anthropic.com>
Base automatically changed from
chore/integrate-splinter-into-codegen
to
main
December 16, 2025 17:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnalysisFilterto dynamically build the query by combining the parts withUNION ALL.RuleMetacomment.