chore(splinter): integrate with codegen #618
Merged
+2,829
−183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteinroe
force-pushed
the
refactor/rules
branch
from
83c2924 to
dc098c0
Compare
psteinroe
force-pushed
the
chore/integrate-splinter-into-codegen
branch
from
f1f3eb0 to
67c3a79
Compare
Changed pgls_analyse::AnalyserRules to pgls_analyser::LinterRules and fixed import statements to use the correct crate for RuleOptions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
psteinroe
force-pushed
the
chore/integrate-splinter-into-codegen
branch
from
67c3a79 to
d6a616c
Compare
Updated test files to use the new type names after the refactor: - Changed AnalyserOptions to LinterOptions - Changed RuleDiagnostic to LinterDiagnostic - Fixed import paths to import from pgls_analyser instead of pgls_analyse 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Fixed import ordering and line length formatting issues. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Picked up test import fixes from base branch and applied codegen updates. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
psteinroe
force-pushed
the
chore/integrate-splinter-into-codegen
branch
from
d6a616c to
0379759
Compare
Changed SQL file path generation to use relative paths from crate root instead of absolute paths, fixing CI codegen check failures. Also removed unused splinter/unknown category from TypeScript types. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Removed unused `use pgls_analyse::RuleMeta;` import from generated splinter rule files and applied clippy format! macro fix. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
juleswritescode
approved these changes
Dec 16, 2025
Collaborator
juleswritescode
left a comment
juleswritescode
left a comment
There was a problem hiding this comment.
very cool — the sql is just taken from SB, right?
Collaborator
Author
yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the actual changes are just within the codegen task. we now generate config and rule metadata from the sql too.
the flow is now:
rules/directory) from splinter sqlVisitorto collect rule metadata from the registry that loads the generated rule metadata when generating analyser code such as config and docsThis allows us to reuse all existing
analyseinfrastructure outside of theanalyser/ ast-linter.