refactor(analyser): separate concerns #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteinroe
force-pushed
the
refactor/rules
branch
from
83c2924 to
dc098c0
Compare
Changed pgls_analyse::AnalyserRules to pgls_analyser::LinterRules and fixed import statements to use the correct crate for RuleOptions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Updated test files to use the new type names after the refactor: - Changed AnalyserOptions to LinterOptions - Changed RuleDiagnostic to LinterDiagnostic - Fixed import paths to import from pgls_analyser instead of pgls_analyse 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Fixed import ordering and line length formatting issues. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
juleswritescode
approved these changes
Dec 16, 2025
Comment on lines
+23
to
+26
| pub use LinterDiagnostic as RuleDiagnostic; | ||
| pub use LinterRule as Rule; | ||
| pub use LinterRuleContext as RuleContext; | ||
|
|
Collaborator
There was a problem hiding this comment.
sind die Linter-spezifisch? wenn ja, kann das hier IMHo zu verwirrung führen
| pub mod options; | ||
| mod registry; | ||
|
|
||
| // Re-export linter-specific types |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Re-export linter-specific types |
| metadata | ||
| }); | ||
|
|
||
| // Separate function for visiting metadata registry (uses pgls_analyse::RegistryVisitor) |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Separate function for visiting metadata registry (uses pgls_analyse::RegistryVisitor) |
| pub static METADATA: LazyLock<MetadataRegistry> = LazyLock::new(|| { | ||
| let mut metadata = MetadataRegistry::default(); | ||
| visit_registry(&mut metadata); | ||
| // Use a separate visitor for metadata that implements pgls_analyse::RegistryVisitor |
Collaborator
There was a problem hiding this comment.
inwiefern separate? ist das nicht einfach der default?
Collaborator
Author
There was a problem hiding this comment.
vorher hatten wir einen Visitor auf Rule, wo Rule metadaten (RuleMeta) und ein run Methode verlangt hat. dh wir hatten ein tight coupling zwischen metadata declaration und execution von rules. jetzt haben wir zwei visitors: einer der nur über RuleMeta läuft, und einer der auch die execution verlange. letzterer existiert nur noch innerhalb der source code linter crate. deshalb "separate visitor" - es gibt jetzt zwei.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
pgls_analyseandpgls_analyserso that "source code linter"-concerns only live inanalyser.analyseonly contains shared concerns such asRuleMetaand a genericRuleVisitor.This is in preparation for the integration of other type of linters (e.g.
splinter), which will use the same infrastructure as much as possible. Every execution concern was moved topgls_analyser, since other linters will not run on the AST and have a different execution model.