Furthur optimization on task transformation. #750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Logiquo
added
the
core
jhnwu3
requested changes
Dec 24, 2025
Collaborator
jhnwu3
left a comment
jhnwu3
left a comment
There was a problem hiding this comment.
Hey, looks like there's some merge conflicts. 748 has been merged, and I think it works pretty well so far.
But it seems there's a conflict still with this PR for whatever reason.
Logiquo
force-pushed
the
batch-task-transformation
branch
from
f2ab37a to
af96784
Compare
Collaborator
Author
|
Ya, it requres some rebase, i've rebased it. |
jhnwu3
approved these changes
Dec 26, 2025
Collaborator
jhnwu3
left a comment
jhnwu3
left a comment
There was a problem hiding this comment.
lgtm, will definitely need to fix the scratch_dir stuff as it leads to weird issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor: Yongda Fan (yongdaf2@illinois.edu)
Contribution Type: Dataset
Description
Furthur optimization on multi-worker efficiency on task transformation. The runtime can reduce from #748's 2h to 20min.
Files to Review
pyhealth/datasets/base_dataset.py