Skip to content

Conversation

@dumartins
Copy link
Contributor

This PR implements the issue #318 under Hacktoberfest

@vercel
Copy link

vercel bot commented Nov 29, 2025

@dumartins is attempting to deploy a commit to the Suman Kunwar's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Nov 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
learn-javascript Ready Ready Preview Comment Nov 29, 2025 11:35am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new live digital clock example to the repository, implementing issue #318 for Hacktoberfest. The example demonstrates real-time clock display using JavaScript's Date object with a toggle between 12-hour (AM/PM) and 24-hour formats. The implementation includes proper accessibility features, responsive design, and follows the repository's patterns for example projects.

  • Creates a complete digital clock example with hour/minute/second display
  • Implements format toggling between 12-hour and 24-hour time display
  • Includes comprehensive documentation in README.md

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
examples/Live-Digital-Clock/index.html Main HTML structure with semantic markup and accessibility features (aria-live, aria-pressed)
examples/Live-Digital-Clock/styles.css Responsive styling with card-based design, flexbox layout, and mobile breakpoints
examples/Live-Digital-Clock/script.js Clock logic with Date object, format toggling, and automatic updates via setInterval
examples/Live-Digital-Clock/README.md Project documentation explaining functionality and usage instructions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

dumartins and others added 2 commits November 28, 2025 21:41
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Owner

@sumn2u sumn2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work.

Image

Fixes #318

@sumn2u sumn2u merged commit 7ef7b90 into sumn2u:main Nov 29, 2025
3 checks passed
@dumartins dumartins deleted the live-digital-clock branch November 29, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants