Skip to content

Conversation

@mmunin
Copy link
Collaborator

@mmunin mmunin commented Aug 5, 2025

Hi @sumn2u,

Added German translations for the root-level Markdown files – formatting and structure preserved.

I noticed German isn’t listed in LANGS.md or in the language selector (currently: English, नेपाली, Türkiye, Français, Indonesian, Español). Before translating the remaining 100+ files, I’d love to know if German is planned to be supported or displayed.

Happy to continue if it’s going somewhere.
Thanks for reviewing!
Best,
mmunin

@mmunin mmunin requested a review from sumn2u August 5, 2025 13:49
@vercel
Copy link

vercel bot commented Aug 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
learn-javascript ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 1:50pm

@mmunin
Copy link
Collaborator Author

mmunin commented Aug 5, 2025

Hi, While translating the docs to German, I noticed a few small issues in the original English files – might be worth checking other languages as well:

date-and-time.md: 
toUTC() doesn’t exist in JS – maybe replace with Date.UTC() or similar.

events.md: 
Line 38 – onkeydown triggers on key press, not release.

References.md: 
Entries could be sorted alphabetically and consistently end with a period.

regular-expressions.md:
    “RegEx constructor” should be “RegExp constructor”.
    Typos: “excpet” → “except”, “digiti” → “digit”.

Happy to fix these if useful. Cheers!

Copy link
Owner

@sumn2u sumn2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumn2u sumn2u merged commit b11cd88 into sumn2u:main Aug 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants