Drop response ID field and restructure TestCase type #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove ID field from responses while keeping it required in requests. Response IDs are unnecessary since test cases are executed sequentially against handlers. Restructure TestCase to use explicit Request and Response fields instead of flat structure, making validation against future JSON schemas easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes ID field from responses while keeping it required in requests.
ResponseIDs are unnecessary since test cases are executed sequentially against handlers. (As discussed on IRC)Restructures
TestCaseto use explicitRequestandResponsefields instead of flat structure, making validation against future JSON schemas easier. (See #10 (comment))Impact on Handlers
Handlers no longer need to track and echo request IDs in their responses. The request structure remains unchanged, and the
TestCaserestructuring has no effect on handlers since it only affects test file format, not the protocol.