(Mac dev-only) fix version mismatch between obs-studio-client.node & obs64 if dev using OSN.app bundle #1601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing local mac development issue where there was an edge case for a version mismatch between client native node vs obs64. Also update README to demonstrate user is required to use absolute path for
CMAKE_INSTALL_PREFIXMotivation and Context
If developer is using OSN.app bundle (so browser sources work due to Google Chromium restrictions where it needs an app bundle to find the
obs64helper apps to enable the browser), then there was an edge case where desktop/node_modules/obs-studio-client.node file could end up with a version mismatch against OSN.app/distribute/bin/obs64. Updating themodule.tsfile to look for the native node module in the developer-only OSN.app bundle (instead of the other desktop/node_modules/obs-client.node file) to resolve any possibility of a version mismatch.How Has This Been Tested?
Built a Desktop app bundle and made sure that still worked. Also verified the local build worked properly when ran directly via
yarn startor via visual studio code.Types of changes
Checklist: