test: add fee timer blocking test coverage #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjors
reviewed
Nov 28, 2025
| TPTester tester{opts}; | ||
|
|
||
| tester.handshake(); | ||
| tester.handshake(); |
Collaborator
There was a problem hiding this comment.
I don't know why the original has two handshake calls, that might be a bug.
It would be good to reduce the amount of duplicated test code, that also makes it more clear how each test case is different.
Contributor
Author
There was a problem hiding this comment.
let me do a clean up and have a much clearer approach
xyephy
force-pushed
the
2025/11/fee-timer-test
branch
from
fffb55b to
d54d4b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test coverage for the fee-based rate limiting timer that was marked with a TODO in template_provider.cpp. The timer blocks fee-based template updates until fee_check_interval seconds have passed (-sv2interval flag).
The test uses is_test=false to exercise the actual timer logic that is normally bypassed in tests. It verifies:
Also adds a TPTester constructor overload to accept custom options, allowing tests to configure is_test and fee_check_interval independently.
Closes #67