fix(win): replace deprecated WMIC by powershell command #110
+4
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes stm32duino#109 Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the deprecated WMIC command with a PowerShell equivalent for detecting USB mass storage devices by volume name on Windows systems.
Key Changes:
- Replaced WMIC LOGICALDISK query with PowerShell's Get-CimInstance cmdlet
- Simplified the logic by removing intermediate variable assignments
- Updated the command to filter for removable drives (DriveType = 2)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109
Search hardened by filtering with device type, only removable device are considered.