Skip to content

Conversation

@usbalbin
Copy link
Member

@usbalbin usbalbin commented May 12, 2025

Demacrofy ADC and move clock logic that is common for the group from Adc<...> to AdcCommon<...>

Fixes #181
Fixes #124 (most likely)

@usbalbin usbalbin marked this pull request as ready for review May 13, 2025 16:45
@usbalbin
Copy link
Member Author

cc @burrbull

))]
use crate::stm32::TIM20;
#[cfg(any(
feature = "stm32g471",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is wrong with stm32g471?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not for the life of me even find a datasheet for it. And I can not seem to find where to buy it either. I have checked mouser, digikey and lcsc. From what I can tell it is only mentioned in the reference manual. It does not even exist on ST's site

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 71 seems to be the only variant without an AES unit. It probably fell out of favor and as such was discontinued. The datasheet isn't even distributed anymore.

usbalbin and others added 6 commits May 15, 2025 14:07
Split out common adc parts to avoid safety issues

Clean up adc

Update tests and examples for adc changes

Use indices for arrayified fields
@usbalbin usbalbin merged commit d4ba734 into stm32-rs:main May 15, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ADC - Unsafe reset parameter ADC calibration should be done after setting the clock mode

3 participants