Skip to content

Enable *and* reset gpio in split method #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Enable *and* reset gpio in split method #182

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fe9197
Enable *and* reset gpio in split method
usbalbin Jan 30, 2025
72a956b
fmt
usbalbin Jan 30, 2025
b40ad2f
Undo exclusive to shared rcc ref in gpio split
usbalbin Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/gpio.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//! General Purpose Input / Output
use core::marker::PhantomData;

use crate::rcc::Rcc;
use crate::rcc::{Enable, Rcc, Reset};
use crate::stm32::EXTI;
use crate::syscfg::SysCfg;

Expand All @@ -14,7 +14,7 @@ pub trait GpioExt {
type Parts;

/// Splits the GPIO block into independent pins and registers
fn split(self, rcc: &mut Rcc) -> Self::Parts;
fn split(self, rcc: &Rcc) -> Self::Parts;
Copy link
Member Author

@usbalbin usbalbin Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, unrelated to #180, since Enable::enable and Reset::reset use bit banding, we do not need exclusive access to the rcc right?

Copy link
Member Author

@usbalbin usbalbin Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove this and perhaps do that later

}

/// Input mode (type state)
Expand Down Expand Up @@ -256,8 +256,10 @@ macro_rules! gpio {
impl GpioExt for $GPIOX {
type Parts = Parts;

fn split(self, rcc: &mut Rcc) -> Parts {
rcc.rb.ahb2enr.modify(|_, w| w.$iopxenr().set_bit());
fn split(self, rcc: &Rcc) -> Parts {
$GPIOX::enable(&rcc.rb);
$GPIOX::reset(&rcc.rb);

Parts {
$(
$pxi: $PXi { _mode: PhantomData },
Expand Down
Loading