Handle non-WouldBlock errors in smoltcp::phy::Device
#102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
datdenkikniet
force-pushed
the
smoltcp-panic
branch
6 times, most recently
from
d6f83c5 to
5962308
Compare
datdenkikniet
force-pushed
the
smoltcp-panic
branch
from
5962308 to
54b332b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #100, I realized that
unwrapcomment was correct, but incomplete:WouldBlockis not the only error that can occur.Instead of
unwrap()-ing, actually handle all error cases and print appropriate messages.