Skip to content

Conversation

@Myzhar
Copy link
Member

@Myzhar Myzhar commented Nov 21, 2025

  • support the new ZED SDK v5.1 virtual stereo API without ZED Media Server
  • automatic baseline from conf file
  • TF update using the baseline information from the SDK conf file

@Myzhar Myzhar self-assigned this Nov 21, 2025
@Myzhar Myzhar requested a review from Copilot November 21, 2025 18:18
Copilot finished reviewing on behalf of Myzhar November 21, 2025 18:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the new ZED SDK v5.1 virtual stereo API, eliminating the need for ZED Media Server. The key changes include:

  • New launch arguments and parameters for configuring virtual stereo cameras using serial numbers or camera IDs
  • Automatic baseline calculation from SDK calibration files instead of manual configuration
  • Enhanced TF broadcasting with static transforms when IPC is disabled and improved debug logging

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
zed_wrapper/launch/zed_camera.launch.py Removed custom_baseline argument; added serial_numbers and camera_ids arguments for virtual stereo setup
zed_wrapper/config/common_stereo.yaml Added debug_tf configuration option
zed_components/src/zed_camera_one/src/zed_camera_one_component_sensors.cpp Updated IMU TF publishing to use static broadcaster when IPC is disabled
zed_components/src/zed_camera_one/src/zed_camera_one_component_main.cpp Added IPC detection and SDK version validation improvements
zed_components/src/zed_camera_one/include/zed_camera_one_component.hpp Added member variables for IPC, debug TF, and static broadcasters
zed_components/src/zed_camera/src/zed_camera_component_video_depth.cpp Updated stereo image frame ID from mCameraFrameId to mCenterFrameId
zed_components/src/zed_camera/src/zed_camera_component_main.cpp Implemented virtual stereo setup logic, baseline-based TF publishing, and frame ID refactoring
zed_components/src/zed_camera/include/zed_camera_component.hpp Added virtual camera parameters and reorganized frame ID declarations
zed_components/src/tools/src/sl_tools.cpp Added parseStringVector_int function and renamed parseStringVector to parseStringMultiVector_float
zed_components/src/tools/include/sl_tools.hpp Updated function declarations for parsing utilities
zed_components/src/tools/include/sl_logging.hpp Added DEBUG_TF logging macros
CHANGELOG.rst Documented new virtual stereo API support and related changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Myzhar and others added 3 commits November 21, 2025 19:22
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Myzhar Myzhar requested a review from Copilot November 21, 2025 18:24
Copilot finished reviewing on behalf of Myzhar November 21, 2025 18:28
Copilot finished reviewing on behalf of Myzhar November 24, 2025 17:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 10 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Myzhar Myzhar requested a review from Copilot November 24, 2025 18:02
Copilot finished reviewing on behalf of Myzhar November 24, 2025 18:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot finished reviewing on behalf of Myzhar November 24, 2025 18:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Myzhar Myzhar requested a review from Copilot November 24, 2025 18:57
Copilot finished reviewing on behalf of Myzhar November 24, 2025 19:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Myzhar and others added 2 commits November 24, 2025 20:03
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Myzhar Myzhar marked this pull request as ready for review November 24, 2025 19:04
@Myzhar Myzhar merged commit a978896 into master Dec 1, 2025
@Myzhar Myzhar deleted the add_new_virtual_stereo branch December 1, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants