Align Renderer more with CommonMark Spec #18
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanzweifel
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #17.
This PR tries to align the package a bit more to the CommonMark spec.
For fun, I've taken the
sample.mdfrom thephpleague/commonmark and written a small test that compares input and output.For convenience, the output is stored to disk for easier comparison in a local file editor.
Some things I noticed
ThematicBreakRenderer: Currently just returns---as the commonmark-package itself doesn't store which characters were used to create the thematic break (eg.***or* * *)\nin random places feels ickyI've fixed some of the "issues" I noticed when comparing
sample.mdandsample-result.mdin Sublime Text on my local machine.I would like to spend my time on some different projects in the next few weeks, and will leave the underlying issue open for others to contribute to. (Will probably merge this PR, so the fixes added here make it into the next release)