feat: add `number/float16/base/from-word` #8733

gururaj1512 · 2025-12-03T09:01:47Z

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

feat: add number/float16/base/from-word

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

Copilot

Copilot wasn't able to review any files in this pull request.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

stdlib-bot · 2025-12-03T09:03:27Z

Coverage Report

Package	Statements	Branches	Functions	Lines
number/float16/base/from-word	$\color{green}148/148$ $\color{green}+0.00%$	$\color{green}16/16$ $\color{green}+0.00%$	$\color{green}1/1$ $\color{green}+0.00%$	$\color{green}148/148$ $\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

gururaj1512 · 2025-12-03T09:03:34Z

/stdlib update-copyright-years

kgryte · 2025-12-03T10:15:17Z

lib/node_modules/@stdlib/number/float16/base/from-word/lib/main.js

+var MANTISSA_MASK = 0x03FF; // 0x03FF = 1023 => 0 00000 1111111111
+
+var NUM_MANTISSA_BITS = 10; // Number of mantissa bits in float16
+var MAX_EXPONENT = 31;      // Maximum exponent value


A couple of follow-up PRs: similar to constants/float64 and constants/float32, we should move these constants to standalone packages in the constants/float16 namespace.

I couldn't find any constant similar to MAX_EXPONENT. Do something similar exist in constants/float[32/64] or should I create it with name constants/float16/max-exponent

See the max-base(10|2)-exponent packages.

These are present for both float32 and float64 and may be what you are looking for.

The FLOAT16_MAX_BASE2_EXPONENT would return 15

What about the base 10 exponent?

base 10 exponent would return 4.
Actually we can take this as

var MAX_EXPONENT = pow( 2, FLOAT16_NUM_EXPONENT_BITS ) - 1;

Works for me. Although, essentially, 31 = MAX_BASE2_EXPONENT*2 + 1. Not sure if that helps convey the meaning/significance here of 31. I suppose the intent here is what is the value of 11111, which is 31, so your formula works. Although, I would recommend using exp2, rather than pow.

lib/node_modules/@stdlib/number/float16/base/from-word/lib/main.js

gururaj1512 · 2025-12-04T07:58:16Z

/stdlib merge

…ase-from-word

gururaj1512 · 2025-12-04T09:25:33Z

Need #8771 to be merged first

kgryte · 2025-12-04T11:13:14Z

/stdlib merge

lib/node_modules/@stdlib/number/float16/base/from-word/README.md

…ase-from-word

kgryte · 2025-12-04T11:15:25Z

lib/node_modules/@stdlib/number/float16/base/from-word/README.md

+var arr = uniform( 1000, 0.0, MAX_UINT16 );
+
+// Round each number:
+var word = map( arr, naryFunction( round, 1 ) );


Would it make more sense to just use random/array/discrete-uniform instead? Then you don't need two separate steps.

kgryte · 2025-12-04T11:16:08Z

lib/node_modules/@stdlib/number/float16/base/from-word/benchmark/benchmark.js

+	var y;
+	var i;
+
+	x = uniform( 100, 0.0, MAX_UINT16 );


Same thing regarding discrete-uniform.

kgryte · 2025-12-04T11:16:50Z

lib/node_modules/@stdlib/number/float16/base/from-word/examples/index.js

+var fromWord = require( './../lib' );
+
+// Generate an array of random numbers:
+var arr = uniform( 1000, 0.0, MAX_UINT16 );


Same comment as README.

kgryte · 2025-12-04T11:20:17Z

lib/node_modules/@stdlib/number/float16/base/from-word/lib/main.js

+			return 0.0;
+		}
+		// Subnormal number: (-1)^sign × 2^(-14) × (0.mantissa)
+		f16 = pow( 2.0, SUBNORMAL_EXPONENT ) * ( mantissa / 1024.0 );


Instead of pow( 2.0, exponent ), I suggest using exp2 which is specifically tailored to 2^exp operations.

Ref: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/math/base/special/exp2

Applies here and below.

kgryte · 2025-12-04T11:21:52Z

lib/node_modules/@stdlib/number/float16/base/from-word/lib/main.js

+// VARIABLES //
+
+var MAX_EXPONENT = 31;                              // Maximum exponent value
+var SUBNORMAL_EXPONENT = 1 - FLOAT16_EXPONENT_BIAS; // Minimum exponent for subnormal numbers


I believe we have an equivalent constant in float32/float64 for this, correct? Meaning, is this another opportunity to move into a separate package?

kgryte · 2025-12-04T11:22:28Z

lib/node_modules/@stdlib/number/float16/base/from-word/lib/main.js

+
+// VARIABLES //
+
+var MAX_EXPONENT = 31;                              // Maximum exponent value


As discussed elsewhere, this can become exp2( num_exponent_bits ) - 1.

lib/node_modules/@stdlib/number/float16/base/from-word/docs/repl.txt

Signed-off-by: Athan <kgryte@gmail.com>

gururaj1512 added 2 commits December 3, 2025 14:29

feat: add repl

c6cbc29

Copilot AI review requested due to automatic review settings December 3, 2025 09:01

Copilot AI reviewed Dec 3, 2025

View reviewed changes

stdlib-bot added the Needs Review A pull request which needs code review. label Dec 3, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 3, 2025

chore: update copyright years

32f3fb3

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 3, 2025

kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Dec 3, 2025

kgryte reviewed Dec 3, 2025

View reviewed changes

lib/node_modules/@stdlib/number/float16/base/from-word/lib/main.js Outdated Show resolved Hide resolved

gururaj1512 mentioned this pull request Dec 3, 2025

feat: add constants/float16/sign-mask #8743

Merged

7 tasks

kgryte added the Needs Changes Pull request which needs changes before being merged. label Dec 4, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 4, 2025

Merge remote-tracking branch 'upstream/develop' into number-float16-b…

848bd84

…ase-from-word

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 4, 2025

refactor: use standalone constants

9723c15

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 4, 2025

kgryte reviewed Dec 4, 2025

View reviewed changes

lib/node_modules/@stdlib/number/float16/base/from-word/README.md Outdated Show resolved Hide resolved

Merge remote-tracking branch 'upstream/develop' into number-float16-b…

85fece5

…ase-from-word

kgryte reviewed Dec 4, 2025

View reviewed changes

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 4, 2025

kgryte reviewed Dec 4, 2025

View reviewed changes

lib/node_modules/@stdlib/number/float16/base/from-word/docs/repl.txt Outdated Show resolved Hide resolved

kgryte added 2 commits December 4, 2025 03:23

docs: remove comment

c6f8fea

Signed-off-by: Athan <kgryte@gmail.com>

docs: remove backticks

8877a61

Signed-off-by: Athan <kgryte@gmail.com>


		// VARIABLES //

		var MAX_EXPONENT = 31; // Maximum exponent value

Uh oh!

feat: add number/float16/base/from-word #8733

Are you sure you want to change the base?

feat: add number/float16/base/from-word #8733

Conversation

gururaj1512 commented Dec 3, 2025

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

gururaj1512 commented Dec 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gururaj1512 commented Dec 4, 2025

Uh oh!

gururaj1512 commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kgryte commented Dec 4, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: add `number/float16/base/from-word` #8733

feat: add `number/float16/base/from-word` #8733

stdlib-bot commented Dec 3, 2025 •

edited

Loading

gururaj1512 commented Dec 4, 2025 •

edited

Loading