Skip to content

Conversation

@Amansingh0807
Copy link
Contributor

Resolves a part of #8647.

Description

What is the purpose of this pull request?

This pull request:

  • Refactors the JavaScript benchmark in @stdlib/assert/contains to use @stdlib/string/format for string interpolation instead of string concatenation when specifying the benchmark name

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Changes made:

  • Added @stdlib/string/format import to the MODULES section
  • Replaced string concatenation pkg+':len='+len with format( '%s:len=%d', pkg, len )

Testing:
Ran the benchmark locally using node lib\node_modules\@stdlib\assert\contains\benchmark\benchmark.length.js and verified that:

  • The benchmark executes successfully without errors
  • The formatted benchmark names match the original output exactly (@stdlib/assert/contains:len=10, etc.)
  • All 18 benchmark tests pass

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Dec 1, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 1, 2025

Coverage Report

Package Statements Branches Functions Lines
assert/contains $\color{green}155/155$
$color{green}+100.00%$
$\color{green}18/18$
$color{green}+100.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}155/155$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added Benchmarks Pull requests adding or improving benchmarks for measuring performance. and removed Needs Review A pull request which needs code review. labels Dec 2, 2025
@kgryte kgryte changed the title bench: refactor to use string interpolation in assert/contains bench: refactor to use string interpolation in assert/contains Dec 2, 2025
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte
Copy link
Member

kgryte commented Dec 2, 2025

@Planeshifter We seem to be getting failing tests in the ESLint first-unit-test lint rule.

@kgryte
Copy link
Member

kgryte commented Dec 2, 2025

As the CI failure does not come from changes introduced in this PR, I will go ahead and merge.

@kgryte kgryte merged commit 2662635 into stdlib-js:develop Dec 2, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants