-
-
Notifications
You must be signed in to change notification settings - Fork 994
feat: migrate utils/none-own-by to object/none-own-by
#8678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit removes the `noneOwnBy` symbol from the `@stdlib/utils` namespace due to a package migration. BREAKING CHANGE: remove `noneOwnBy` To migrate, users should access the same symbol via the `@stdlib/object` namespace. Ref: stdlib-js#6804
This commit removes `@stdlib/utils/none-own-by` in favor of `@stdlib/object/none-own-by`. BREAKING CHANGE: remove `utils/none-own-by` To migrate, users should update their require/import paths to use `@stdlib/object/none-own-by` which provides the same API and implementation. Ref: stdlib-js#6804
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
The CI failures are not due to anything done in this PR, so should be fine to mark ready for review. |
|
@kgryte alright |
|
@kgryte Let me also take a look into what's causing this error specific for typescript declarations. |
Ref: stdlib-js#8678 Signed-off-by: Athan <kgryte@gmail.com>
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after fixing a typo
|
As the CI failure is not due to changes introduced in this PR, I'll go ahead and merge. |
Resolves #6804.
Description
This pull request:
utils/none-own-bytoobject/none-own-byRelated Issues
This pull request has the following related issues:
utils/none-own-bytoobject/none-own-by#6804Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers