-
-
Notifications
You must be signed in to change notification settings - Fork 978
feat!: migrate utils/any-in-by to object/any-in-by
#8629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: migrate utils/any-in-by to object/any-in-by
#8629
Conversation
This commit removes `@stdlib/utils/any-in-by` in favor of `@stdlib/object/any-in-by`. BREAKING CHANGE: remove `utils/any-in-by` To migrate, users should update their require/import paths to use `@stdlib/object/any-in-by` which provides the same API and implementation. Ref: stdlib-js#6754
Coverage Report
The above coverage report was generated for the changes in this PR. |
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I am a bit surprised that the README lint error made it through our Git commit hooks, as local linting should have caught this before pushing to the remote. You should confirm that your local dev environment is properly setup.
For these PRs, there should be 4 and only 4 commits. See https://github.com/stdlib-js/stdlib/blob/develop/docs/contributing/moving_packages.md. If you need additional commits, you need to start over.
Furthermore, your "refactor" commit is incorrect. Please follow the guide. Namely, when updating the namespace to remove the exported symbol, that should be a separate commit. See steps 6 and 7: https://github.com/stdlib-js/stdlib/blob/develop/docs/contributing/moving_packages.md#6-remove-the-export-of-the-original-package-from-its-parent-namespace. If you don't do this, this messes up our changelog. I'll allow this PR to move through only because the namespace export is highly unlikely to have high usage atm.
Any future PRs which don't follow the documented sequence will be automatically closed going forward.
Resolves #6754.
Description
This pull request:
utils/any-in-bytoobject/any-in-byRelated Issues
This pull request has the following related issues:
utils/any-in-bytoobject/any-in-by#6754Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers