Skip to content

Conversation

@Neerajpathak07
Copy link
Member

Resolves #6754.

Description

What is the purpose of this pull request?

This pull request:

  • Migrates utils/any-in-by to object/any-in-by

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

This commit removes `@stdlib/utils/any-in-by` in favor of
`@stdlib/object/any-in-by`.

BREAKING CHANGE: remove `utils/any-in-by`

To migrate, users should update their require/import paths to use
`@stdlib/object/any-in-by` which provides the same API and implementation.

Ref: stdlib-js#6754
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 29, 2025

Coverage Report

Package Statements Branches Functions Lines
namespace/alias2pkg $\color{green}95/95$
$color{green}+10.47%$
$\color{green}7/7$
$color{green}+0.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}95/95$
$color{green}+10.47%$
namespace $\color{red}39324/39427$
$color{red}--0.26%$
$\color{green}112/112$
$color{green}+0.00%$
$\color{red}2/11$
$color{red}--81.82%$
$\color{red}39324/39427$
$color{red}--0.26%$
namespace/pkg2alias $\color{green}100/100$
$color{green}+14.94%$
$\color{green}10/10$
$color{green}+0.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}100/100$
$color{green}+14.94%$
namespace/pkg2related $\color{green}100/100$
$color{green}+14.94%$
$\color{green}10/10$
$color{green}+0.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}100/100$
$color{green}+14.94%$
namespace/pkg2standalone $\color{green}95/95$
$color{green}+10.47%$
$\color{green}7/7$
$color{green}+0.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}95/95$
$color{green}+10.47%$
namespace/standalone2pkg $\color{green}95/95$
$color{green}+10.47%$
$\color{green}7/7$
$color{green}+0.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}95/95$
$color{green}+10.47%$
object/any-in-by $\color{red}123/125$
$color{green}+98.40%$
$\color{red}9/10$
$color{green}+90.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{red}123/125$
$color{green}+98.40%$
object/none-in-by $\color{green}117/117$
$color{green}+100.00%$
$\color{green}10/10$
$color{green}+100.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}117/117$
$color{green}+100.00%$
object/some-in-by $\color{red}132/133$
$color{green}+99.25%$
$\color{red}13/14$
$color{green}+92.86%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{red}132/133$
$color{green}+99.25%$
utils/any-own-by $\color{green}123/123$
$color{green}+19.42%$
$\color{green}10/10$
$color{green}+0.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}123/123$
$color{green}+19.42%$
utils $\color{red}45912/62232$
$color{red}--26.22%$
$\color{red}767/811$
$color{red}--5.43%$
$\color{red}23/513$
$color{red}--95.52%$
$\color{red}45912/62232$
$color{red}--26.22%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review November 29, 2025 17:21
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Nov 29, 2025
@Neerajpathak07 Neerajpathak07 added the release: Major Breaking change requiring a new major release. label Nov 29, 2025
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Nov 29, 2025
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am a bit surprised that the README lint error made it through our Git commit hooks, as local linting should have caught this before pushing to the remote. You should confirm that your local dev environment is properly setup.

For these PRs, there should be 4 and only 4 commits. See https://github.com/stdlib-js/stdlib/blob/develop/docs/contributing/moving_packages.md. If you need additional commits, you need to start over.

Furthermore, your "refactor" commit is incorrect. Please follow the guide. Namely, when updating the namespace to remove the exported symbol, that should be a separate commit. See steps 6 and 7: https://github.com/stdlib-js/stdlib/blob/develop/docs/contributing/moving_packages.md#6-remove-the-export-of-the-original-package-from-its-parent-namespace. If you don't do this, this messes up our changelog. I'll allow this PR to move through only because the namespace export is highly unlikely to have high usage atm.

Any future PRs which don't follow the documented sequence will be automatically closed going forward.

@kgryte kgryte merged commit f03b259 into stdlib-js:develop Nov 29, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: Major Breaking change requiring a new major release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: migrate utils/any-in-by to object/any-in-by

3 participants