Skip to content

Conversation

@DivyanshuVortex
Copy link
Contributor


type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed
    Resolves None.

Description

This pull request:

feat : add stats/base/ndarray/dmidrange

Related Issues

This pull request has the following related issues:

  • None .

Questions

No.

Other

No.

Checklist

AI Assistance

  • Yes
  • No

How was AI assistance used?

  • Code generation
  • Test/benchmark generation
  • Documentation
  • Research and understanding

Disclosure

I consulted ChatGPT for clarification on documentation format and contribution structure. All implementation logic, tests, and documentation were written manually.


@stdlib-js/reviewers

…for midrange implementation

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Nov 28, 2025
@DivyanshuVortex DivyanshuVortex marked this pull request as draft November 28, 2025 21:25
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Nov 28, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 28, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/base/ndarray/dmidrange $\color{green}101/101$
$color{green}+100.00%$
$\color{green}3/3$
$color{green}+100.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}101/101$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@DivyanshuVortex DivyanshuVortex marked this pull request as ready for review November 28, 2025 21:42
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Nov 28, 2025
@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Nov 29, 2025
Signed-off-by: Athan <kgryte@gmail.com>

x = new Float64Array( [ 1.0, -2.0, NaN, 2.0 ] );

v = dmidrange( [ vector( x, 4, 1, 0 ) ] );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are lacking tests which actually demonstrate that the function computes the midrange.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DivyanshuVortex These tests still need updating. See the stats/strided/dmidrange package tests for inspiration.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs updating.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left an initial round of comments. This PR needs significant clean-up before it can move forward.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Nov 29, 2025
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left another round of comments.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Nov 29, 2025
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@DivyanshuVortex
Copy link
Contributor Author

hi @kgryte ,
CI EditorConfig check is failing due to GitHub API rate limit while downloading editorconfig-checker. Local lint passes. Can someone please re-run or update the workflow?

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Nov 30, 2025
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Nov 30, 2025
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from tests, this PR is shaping up and close to ready for merge.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants