-
-
Notifications
You must be signed in to change notification settings - Fork 982
feat: add stats/base/ndarray/dmidrange
#8626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: add stats/base/ndarray/dmidrange
#8626
Conversation
…for midrange implementation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
Coverage Report
The above coverage report was generated for the changes in this PR. |
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/docs/repl.txt
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/examples/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/lib/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/package.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/test/test.js
Outdated
Show resolved
Hide resolved
|
|
||
| x = new Float64Array( [ 1.0, -2.0, NaN, 2.0 ] ); | ||
|
|
||
| v = dmidrange( [ vector( x, 4, 1, 0 ) ] ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are lacking tests which actually demonstrate that the function computes the midrange.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DivyanshuVortex These tests still need updating. See the stats/strided/dmidrange package tests for inspiration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs updating.
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/test/test.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/test/test.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/test/test.js
Outdated
Show resolved
Hide resolved
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left an initial round of comments. This PR needs significant clean-up before it can move forward.
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/README.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/examples/index.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/lib/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/lib/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/lib/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/package.json
Outdated
Show resolved
Hide resolved
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left another round of comments.
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: passed
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
|
hi @kgryte , |
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/lib/main.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/stats/base/ndarray/dmidrange/lib/main.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from tests, this PR is shaping up and close to ready for merge.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
Resolves None.
Description
This pull request:
feat : add stats/base/ndarray/dmidrange
Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
How was AI assistance used?
Disclosure
I consulted ChatGPT for clarification on documentation format and contribution structure. All implementation logic, tests, and documentation were written manually.
@stdlib-js/reviewers