Skip to content

Conversation

@DivyanshuVortex
Copy link
Contributor

@DivyanshuVortex DivyanshuVortex commented Nov 28, 2025

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:

task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: passed
task: lint_package_json status: passed
task: lint_repl_help status: passed
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: passed
task: lint_javascript_tests status: passed
task: lint_javascript_benchmarks status: passed
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: na
task: lint_c_examples status: na
task: lint_c_benchmarks status: na
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: passed
task: lint_typescript_tests status: passed
task: lint_license_headers status: passed



Checklist

Please ensure the following tasks are completed before submitting this pull request.


Resolves: None

Description

This pull request adds a new package:

feat: add stats/base/ndarray/mode

Provides an implementation for computing the mode of a one-dimensional ndarray with support for arbitrary strides, offsets, and negative strides. Includes documentation, tests, benchmarks, examples, and REPL help.


Checklist

  • Read, understood, and followed the contributing guidelines.
  • All lint checks passed.
  • Includes full examples, benchmarks, tests, and documentation.

Related Issues

None.


Questions

No questions for reviewers.


Other

No additional notes.


AI Assistance

Did you use AI assistance?
No


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Nov 28, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@DivyanshuVortex DivyanshuVortex changed the title feat/quantile feat: add stats/base/ndarray/quantile Nov 28, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/ndarray/quantile $\color{green}136/136$
$color{green}+100.00%$
$\color{red}9/10$
$color{green}+90.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}136/136$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@DivyanshuVortex
Copy link
Contributor Author

Hello @kgryte,

Apologies for taking your time. I’m encountering the following ESLint error and I’m unsure why it’s happening or how to resolve it:

`Oops! Something went wrong! :(

ESLint: 8.57.1

TypeError: Cannot read properties of undefined (reading 'body')
`

Could you please clarify what typically causes this issue and what I might be missing in my setup or implementation?

Thank you.

@kgryte
Copy link
Member

kgryte commented Nov 28, 2025

@DivyanshuVortex There is a fairly clear reason why lint is failing. Namely, you didn't follow our conventions when writing test files. Take a look at your test file and then compare to every other test file in the project and spot the differences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants