-
-
Notifications
You must be signed in to change notification settings - Fork 976
chore: fix JavaScript lint errors (issue #5377) #8591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
I've updated the PR description to include the contributing guidelines acknowledgement. |
e9e5c55 to
1d84ee1
Compare
|
Hi maintainers - I updated the PR description and pushed a GPG-signed commit. Could someone please approve the workflow runs for this fork so CI can execute? Thanks! |
|
@stdlib-bot maintainers Could someone please approve the workflows and review this PR? Thanks! |
|
I noticed your PR description contains closing keywords ("Resolves", "Closes", or "Fixes") referencing a "Tracking Issue". Why this matters: Required action: Thank you for your contribution to the project! |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
Hi @stdlib-bot - I’ve updated the PR description as requested (replaced “Resolves” with “Progresses” and added the contributing-guidelines acknowledgment). Could you please re-check the PR and allow a maintainer to approve the workflow runs? |
Progresses #5377
Description
This pull request:
replaces the obsolete sqrt precision script with a self-contained, lint-compliant version that uses @StdLib’s sqrt and avoids console log debug.
Related Issues
Progresses Tracking issue: Resolve JavaScript lint errors Tracking issue: Resolve JavaScript lint errors #5377
Checklist