feat: add ndarray/concat1d
#8584
Open
+2,157
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headlessNode
added
Feature
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
Nov 26, 2025
| if ( arrs.length >= 1 ) { | ||
| dt = resolveDataTypes( arrs ); | ||
| ord = resolveOrder( arrs ); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| } | |
| } else { | |
| dt = DEFAULT_DTYPE; | |
| ord = DEFAULT_ORDER; | |
| } |
kgryte
reviewed
Nov 26, 2025
Comment on lines
+118
to
+119
| } else if ( !dt && !ord ) { | ||
| args[ i ] = broadcastScalar( args[ i ], DEFAULT_DTYPE, [ 1 ], DEFAULT_ORDER ); // eslint-disable-line max-len |
Member
There was a problem hiding this comment.
Suggested change
| } else if ( !dt && !ord ) { | |
| args[ i ] = broadcastScalar( args[ i ], DEFAULT_DTYPE, [ 1 ], DEFAULT_ORDER ); // eslint-disable-line max-len |
This branch doesn't seem to be necessary if you resolve defaults above in the case where only scalars have been provided.
kgryte
reviewed
Nov 26, 2025
| args[ i ] = broadcastScalar( args[ i ], dt, [ 1 ], ord ); | ||
| } | ||
| } | ||
| return concat( normalizeArrays( args ) ); |
Member
There was a problem hiding this comment.
Why are you "normalizing" arrays here? Not clear why this is necessary.
kgryte
added
Needs Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves stdlib-js/metr-issue-tracker#116.
Description
This pull request:
ndarray/concat1dRelated Issues
This pull request has the following related issues:
ndarray/concat1dmetr-issue-tracker#116Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers