Skip to content

Conversation

@Prasad1-S
Copy link

@Prasad1-S Prasad1-S commented Nov 13, 2025

🧹 Linting Fixes Summary

This commit resolves 11 linting errors across multiple files in the stdlib repository.

Changes Made:

Benchmark File Spacing (benchmark.js)

File: benchmark.js

Lines: 72–76, 137–140

Issue: No spaces allowed between closing parenthesis/bracket and nested object/array expressions

Fix: Removed spaces before closing parentheses in function calls (e.g., } ) → }))

Array Constructor (resolve.sync.js)

File: resolve.sync.js

Line: 59

Issue: Using new Array() constructor is not allowed

Fix: Replaced new Array(len) with array literal [] for better performance and consistency

TypeScript Type Annotations (is-truthy)

File: index.d.ts

Line: 59

Issue: Unexpected any type

Fix: Changed any → unknown for better type safety

TypeScript Type Annotations (next-dtype)

File: index.d.ts

Line: 37

Issue: Unexpected any types in function signature

Fix: Replaced generic any with union type string | number | null | object

Quote Style (R Benchmark)

File: benchmark.R

Lines: 28, 37, 48–52

Issue: Only single quotes allowed, found double quotes

Fix: Changed all " to ' throughout the benchmark file

Undefined Term (5d.js)

File: 5d.js

Line: 188

Issue: Unknown word ztest in documentation example

Fix: Changed ztest → z_test

🧠 Impact

All 11 linting errors resolved

Improved code quality and consistency

Better TypeScript type safety

Maintains compatibility with existing code

✅ Acknowledgment

@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Nov 13, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
assert/is-truthy $\color{green}129/129$
$color{green}+100.00%$
$\color{green}5/5$
$color{green}+100.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}129/129$
$color{green}+100.00%$
ndarray/base/unary-reduce-strided1d-assign-struct $\color{red}5091/8179$
$color{green}+62.24%$
$\color{green}29/29$
$color{green}+100.00%$
$\color{red}0/33$
$color{green}+0.00%$
$\color{red}5091/8179$
$color{green}+62.24%$
ndarray/next-dtype $\color{green}119/119$
$color{green}+100.00%$
$\color{green}9/9$
$color{green}+100.00%$
$\color{green}2/2$
$color{green}+100.00%$
$\color{green}119/119$
$color{green}+100.00%$
ndarray/slice-to $\color{green}221/221$
$color{green}+100.00%$
$\color{green}24/24$
$color{green}+100.00%$
$\color{green}2/2$
$color{green}+100.00%$
$\color{green}221/221$
$color{green}+100.00%$
stats/base/dists/laplace/quantile $\color{green}299/299$
$color{green}+100.00%$
$\color{green}23/23$
$color{green}+100.00%$
$\color{green}4/4$
$color{green}+100.00%$
$\color{green}299/299$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@Prasad1-S
Copy link
Author

updated the guidline acknowledgement

@Prasad1-S
Copy link
Author

I added the Acknowledgement in my PR description

@kgryte
Copy link
Member

kgryte commented Nov 13, 2025

This PR contains a number of changes which are unrelated to the upstream issue. See #8519 for what we were looking for. As #8519 is already complete, I'll go ahead and close this PR.

Thank you for your interest in stdlib, and we look forward to your future contributions!

@kgryte kgryte closed this Nov 13, 2025
@kgryte kgryte added Duplicate This issue or pull request already exists. and removed Needs Review A pull request which needs code review. labels Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Duplicate This issue or pull request already exists. First-time Contributor A pull request from a contributor who has never previously committed to the project repository.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants