-
-
Notifications
You must be signed in to change notification settings - Fork 963
chore: Fix JavaScript lint errors (issue ##8515) #8518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
updated the guidline acknowledgement |
|
I added the Acknowledgement in my PR description |
🧹 Linting Fixes Summary
This commit resolves 11 linting errors across multiple files in the stdlib repository.
Changes Made:
Benchmark File Spacing (benchmark.js)
File: benchmark.js
Lines: 72–76, 137–140
Issue: No spaces allowed between closing parenthesis/bracket and nested object/array expressions
Fix: Removed spaces before closing parentheses in function calls (e.g., } ) → }))
Array Constructor (resolve.sync.js)
File: resolve.sync.js
Line: 59
Issue: Using new Array() constructor is not allowed
Fix: Replaced new Array(len) with array literal [] for better performance and consistency
TypeScript Type Annotations (is-truthy)
File: index.d.ts
Line: 59
Issue: Unexpected any type
Fix: Changed any → unknown for better type safety
TypeScript Type Annotations (next-dtype)
File: index.d.ts
Line: 37
Issue: Unexpected any types in function signature
Fix: Replaced generic any with union type string | number | null | object
Quote Style (R Benchmark)
File: benchmark.R
Lines: 28, 37, 48–52
Issue: Only single quotes allowed, found double quotes
Fix: Changed all " to ' throughout the benchmark file
Undefined Term (5d.js)
File: 5d.js
Line: 188
Issue: Unknown word ztest in documentation example
Fix: Changed ztest → z_test
🧠 Impact
All 11 linting errors resolved
Improved code quality and consistency
Better TypeScript type safety
Maintains compatibility with existing code
✅ Acknowledgment