Skip to content

Conversation

@DivyanshuVortex
Copy link
Contributor

Resolves #8480

Description

This PR implements the RFC for adding the package assert/has-split-symbol-support.

The package is modeled after existing ones:

  • assert/has-iterator-symbol-support
  • assert/has-is-concat-spreadable-symbol-support
  • assert/has-has-instance-symbol-support

The only functional difference is that this package checks for the existence of Symbol.split.

Implementation steps completed

  • Copied assert/has-iterator-symbol-support
  • Renamed all identifiers and references from iteratorsplit
  • Updated logic to detect Symbol.split
  • Verified correctness with local tests, examples, and benchmarks

Related Issues

None.

Questions

No.

Other

No.

Checklist


AI Assistance

  • Yes
  • No

How AI was used

  • Research and understanding
  • Documentation (including examples)

Disclosure

Used ChatGPT to understand structure the PR description.
All code edits and verification were performed manually.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Nov 11, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 11, 2025

Coverage Report

Package Statements Branches Functions Lines
symbol/search $\color{green}106/106$
$color{green}+100.00%$
$\color{red}2/3$
$color{green}+66.67%$
$\color{green}0/0$
$color{green}+100.00%$
$\color{green}106/106$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@DivyanshuVortex
Copy link
Contributor Author

DivyanshuVortex commented Nov 12, 2025

@kgryte , I'm unable to run the make lint in local
. ESLint couldn't find the plugin "eslint-plugin-stdlib" and even i solve the same issue and re-clone the whole repo again for many time after removing the data of old but the problem is still the problem.
Can you please confirm if eslint-plugin-stdlib was removed, renamed, or relocated?
Would appreciate guidance on how to lint locally now.

@kgryte
Copy link
Member

kgryte commented Nov 12, 2025

@DivyanshuVortex Did you run make init as documented in the development guide?

@kgryte
Copy link
Member

kgryte commented Nov 12, 2025

Signed-off-by: Divyanshu <divyanshuchandra9027@gmail.com>
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add symbol/search

3 participants