-
-
Notifications
You must be signed in to change notification settings - Fork 974
feat: add symbol/replace package #8496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: adity1raut <araut7798@gmail.com>
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
PTAL /cc @kgryte |
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR needs significant clean-up, as there are numerous copy-paste mistakes. You need to be sure to update all content to replace symbol.replace. Currently, you have a number of hasInstance references from the copied packages. All of those need to be addressed before this PR can move forward.
|
Ref: a68d5d9 |
|
Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit. Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. |
Description
Package Overview
The package is modeled after existing symbol utilities in the repository, including:
symbol/has-instancesymbol/iteratorsymbol/async-iteratorsymbol/is-concat-spreadableThe new package exports
Symbol.replacewhen available in the current environment.Additional Implementation Details
(e.g.,
has-instance→replace,HasInstanceSymbol→ReplaceSymbol).Symbol.toStringTag.Related Issues
This pull request has the following related issues:
symbol/replace#8479Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers