Skip to content

feat: add ndarray/base/copy #8329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 1, 2025
Merged

feat: add ndarray/base/copy #8329

merged 4 commits into from
Nov 1, 2025

Conversation

@headlessNode
Copy link
Member

@headlessNode headlessNode commented Oct 31, 2025

Resolves stdlib-js/metr-issue-tracker#105.

Description

What is the purpose of this pull request?

This pull request:

  • add ndarray/base/copy

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Everything generated by Claude Code. I did review the generated code and fixes to test cases and documentation.

@stdlib-js/reviewers

@headlessNode headlessNode added the Feature Issue or pull request for adding a new feature. label Oct 31, 2025
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Oct 31, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Oct 31, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
ndarray/base/copy $\color{green}97/97$
$color{green}+100.00%$ 		$\color{green}3/3$
$color{green}+100.00%$ 		$\color{green}1/1$
$color{green}+100.00%$ 		$\color{green}97/97$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@headlessNode headlessNode requested a review from kgryte October 31, 2025 08:53
@kgryte
chore: clean-up
2ee01f7 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Nov 1, 2025
kgryte
kgryte approved these changes Nov 1, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte kgryte merged commit 4b8a736 into stdlib-js:develop Nov 1, 2025
14 checks passed
@headlessNode headlessNode deleted the ndarray-base-copy branch November 1, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add ndarray/base/copy

3 participants

@headlessNode @stdlib-bot @kgryte