fix: handle missing properties, error types, and stack in @stdlib/error/reviver #6353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: handle missing properties, error types, and stack in @stdlib/error/reviver
This PR fixes three functional bugs in the
@stdlib/error/revivermodule that affect the correctness and reliability of thereviverfunction.Bug Fixes
lib/index.jsreviverfunction did not handle missingmessage,name, orstackproperties, leading to incorrectErrorobjects (e.g., a message of"undefined"ifvalue.messagewas undefined).messageandname, and only setstackif it’s a string.Errorconstructor, ignoring the specific error type (e.g.,SyntaxError,TypeError), causing the revived error to have the wrong type.value.name.stackproperty is not writable orvalue.stackis not a string, which could cause issues in some environments.stackis only set ifvalue.stackis a string and thestackproperty is writable.test/test.jsTypeError) to ensure the fixes are robust.Checklist