feat: add implementation of `stdlib/math/base/special/minmaxabsf` #6290

sahil20021008 · 2025-03-22T11:32:59Z

Resolves #6163 .

Description

What is the purpose of this pull request?

This pull request proposes adding minmaxabsf implementation

This pull request adds minmaxabsf implementation to stdlib. This includes benchmarks, lib files, tests, examples, src files, README, etc

Related Issues

Does this pull request have any related issues?

This pull request:

Progresses [RFC]: Add C implementations to base special math functions (tracking issue) #649

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

stdlib-bot · 2025-03-22T11:33:12Z

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

Please read our contributing guidelines.
Update your pull request description to include this checked box:

- [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

The developer's certificate of origin
Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

stdlib-bot

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

stdlib-bot · 2025-03-22T11:35:14Z

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

Please read our contributing guidelines.
Update your pull request description to include this checked box:

- [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

The developer's certificate of origin
Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

etc/npm/deps.txt

package.json

lib/node_modules/@stdlib/math/base/special/minmaxabsf/manifest.json

anandkaranubc · 2025-03-26T22:27:53Z

/stdlib merge

stdlib-bot · 2025-03-26T22:29:56Z

/stdlib merge

@anandkaranubc, the slash command failed to complete. Please check the workflow logs for details.

View workflow run

anandkaranubc · 2025-03-26T22:37:32Z

@sahil20021008 I left some comments on Gitter. Just referencing them here.

"It's because you updated your local branch with the latest changes from the remote develop branch, and now your PR includes all those new changes as well.

You need to rebase/merge your branch onto the latest develop to clean up the PR. That'll make sure only your actual changes show up in the diff.

Git guide

You seem to have also modified some files like math/base/special/cbrtf which should be reverted."

And that's the reason why the above bot command didn't work.

stdlib-bot · 2025-03-27T18:50:35Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/minmaxabsf	$\color{green}265/265$ $\color{green}+100.00\%$	$\color{green}12/12$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}265/265$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

This commit adds the implementation of stdlib/math/base/special/minmaxabsf function. It includes a README.md file, benchmarks, tests, examples. The minmaxabsf function returns the minimum and maximum single-precision floating-point values for any two numbers. Closes: stdlib-js#6163

This commit adds the implementation of stdlib/math/base/special/minmaxabsf function. It includes a README.md file, benchmarks, tests, examples. The minmaxabsf function returns the minimum and maximum single-precision floating-point values for any two numbers. --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

This commit adds the implementation of stdlib/math/base/special/minmaxabsf function. It includes a README.md file, benchmarks, tests, examples. The minmaxabsf function returns the minimum and maximum single-precision floating-point values for any two numbers. --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

This commit adds the implementation of stdlib/math/base/special/minmaxabsf function. It includes a README.md file, benchmarks, tests, examples. The minmaxabsf function returns the minimum and maximum single-precision floating-point values for any two numbers. --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

This commit adds the implementation of stdlib/math/base/special/minmaxabsf function. It includes a README.md file, benchmarks, tests, examples. The minmaxabsf function returns the minimum and maximum single-precision floating-point values for any two numbers. --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

sahil20021008 · 2025-03-30T10:41:57Z

/stdlib lint-autofix

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

lib/node_modules/@stdlib/math/base/special/minmaxabsf/README.md

lib/node_modules/@stdlib/math/base/special/minmaxabsf/examples/c/example.c

lib/node_modules/@stdlib/math/base/special/minmaxabsf/examples/index.js

kgryte · 2025-04-08T03:44:10Z

lib/node_modules/@stdlib/math/base/special/minmaxabsf/manifest.json

+        "@stdlib/napi/export",
+        "@stdlib/napi/argv-float",
+        "@stdlib/napi/argv-float32array",
+        "@stdlib/math/base/napi/quaternary",


Why do you have this dep?

This dependencies are being used in src/addon.c file

kgryte

Left an initial round of comments.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Planeshifter · 2025-04-10T00:52:32Z

⚠️ Tracking Issue Closure Warning ⚠️

I noticed your PR description contains closing keywords ("Resolves", "Closes", or "Fixes") referencing a "Tracking Issue".

Why this matters:
Tracking issues should typically remain open until all related sub-issues are completed. GitHub automatically closes issues with such closing keywords when the PR is merged. For more information, see GitHub's documentation on using keywords in issues and pull requests.

Required action:
Use "Progresses" instead to reference the tracking issue without automatically closing it.

Thank you for your contribution to the project!

sahil20021008 · 2025-04-10T11:09:16Z

I have changed the PR description as requested.
I have changed "resolves" keywords to "progresses"

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot added the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Mar 22, 2025

stdlib-bot reviewed Mar 22, 2025

View reviewed changes

sahil20021008 changed the title ~~Feature/minmaxabsf~~ feat: Add implementation of stdlib/math/base/special/minmaxabsf Mar 22, 2025

Neerajpathak07 reviewed Mar 22, 2025

View reviewed changes

etc/npm/deps.txt Show resolved Hide resolved

Neerajpathak07 reviewed Mar 22, 2025

View reviewed changes

package.json Show resolved Hide resolved

sahil20021008 mentioned this pull request Mar 23, 2025

[RFC]: Develop C implementations for Base Special math functions stdlib-js/google-summer-of-code#113

Closed

7 tasks

kgryte reviewed Mar 25, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/minmaxabsf/manifest.json Outdated Show resolved Hide resolved

kgryte reviewed Mar 25, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/minmaxabsf/manifest.json Outdated Show resolved Hide resolved

kgryte reviewed Mar 25, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/minmaxabsf/manifest.json Outdated Show resolved Hide resolved

kgryte reviewed Mar 25, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/minmaxabsf/manifest.json Outdated Show resolved Hide resolved

kgryte reviewed Mar 25, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/minmaxabsf/manifest.json Outdated Show resolved Hide resolved

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 26, 2025

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 26, 2025

sahil20021008 force-pushed the feature/minmaxabsf branch from c28e2e2 to 14c36eb Compare March 27, 2025 18:48

stdlib-bot added the Math Issue or pull request specific to math functionality. label Mar 27, 2025

sahil20021008 and others added 9 commits March 28, 2025 19:23

feat!: Committing changes for draft review

f79ffcf

Resolve merge conflicts

f092b66

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 30, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 30, 2025

fix: resolve lint errors

eca6eed

stdlib-bot removed bot: In Progress Pull request is currently awaiting automation. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Mar 30, 2025

sahil20021008 changed the title ~~feat: Add implementation of stdlib/math/base/special/minmaxabsf~~ feat: add implementation of stdlib/math/base/special/minmaxabsf Apr 4, 2025

sahil20021008 added 4 commits April 4, 2025 22:22

sahil20021008 requested review from Neerajpathak07 and kgryte April 7, 2025 19:00