Skip to content

feat: add array/base/reshape #5639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 9, 2025
Merged

feat: add array/base/reshape #5639

merged 9 commits into from
Apr 9, 2025

Conversation

@headlessNode
Copy link
Member

@headlessNode headlessNode commented Mar 1, 2025

Description

What is the purpose of this pull request?

This pull request:

  • adds array/base/reshape including tests, benchmarks and documentation.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

I'm not sure if the function signature is as expected, it was not mentioned in the issue.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@headlessNode
feat: add array/base/reshape
079eeae 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
@headlessNode headlessNode added the Feature Issue or pull request for adding a new feature. label Mar 1, 2025
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 1, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 1, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
array/base/reshape $\color{green}136/136$
$\color{green}+100.00\%$ 		$\color{green}10/10$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}136/136$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@headlessNode headlessNode mentioned this pull request Mar 1, 2025
Closed
headlessNode
headlessNode commented Mar 2, 2025
View reviewed changes
@headlessNode
fix: apply suggestions from code review
9a0737c 
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
kgryte
kgryte reviewed Apr 1, 2025
View reviewed changes
kgryte
kgryte reviewed Apr 1, 2025
View reviewed changes
kgryte
kgryte reviewed Apr 1, 2025
View reviewed changes
kgryte
kgryte reviewed Apr 1, 2025
View reviewed changes
kgryte
kgryte reviewed Apr 1, 2025
View reviewed changes
kgryte
kgryte reviewed Apr 1, 2025
View reviewed changes
kgryte
kgryte reviewed Apr 1, 2025
View reviewed changes
kgryte
kgryte reviewed Apr 1, 2025
View reviewed changes
kgryte
kgryte reviewed Apr 1, 2025
View reviewed changes
kgryte
kgryte reviewed Apr 1, 2025
View reviewed changes
kgryte
kgryte reviewed Apr 1, 2025
View reviewed changes
kgryte
kgryte reviewed Apr 1, 2025
View reviewed changes
kgryte
kgryte reviewed Apr 1, 2025
View reviewed changes
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Apr 1, 2025
@headlessNode
refactor: apply suggestions from code review
26166e1 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@headlessNode
refactor: apply suggestions from code review
38ec46f 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@headlessNode
test: add additional tests
b63180b 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@headlessNode headlessNode added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Apr 6, 2025
@headlessNode
Copy link
Member Author

headlessNode commented Apr 6, 2025

@kgryte Changes applied. Please check.

kgryte
kgryte reviewed Apr 9, 2025
View reviewed changes
kgryte
kgryte reviewed Apr 9, 2025
View reviewed changes
kgryte
kgryte reviewed Apr 9, 2025
View reviewed changes
kgryte
kgryte reviewed Apr 9, 2025
View reviewed changes
@kgryte
Apply suggestions from code review
805670a 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Apr 9, 2025
View reviewed changes
kgryte
kgryte reviewed Apr 9, 2025
View reviewed changes
@kgryte
Apply suggestions from code review
5ec7da2 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Apr 9, 2025
View reviewed changes
kgryte
kgryte reviewed Apr 9, 2025
View reviewed changes
@kgryte
Apply suggestions from code review
bd678c9 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte previously approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kgryte
kgryte reviewed Apr 9, 2025
View reviewed changes
@kgryte
style: fix missing blank line
c28d497 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 9, 2025
@kgryte kgryte merged commit 40de89d into stdlib-js:develop Apr 9, 2025
13 checks passed
anandkaranubc pushed a commit to anandkaranubc/stdlib that referenced this pull request Apr 9, 2025
@headlessNode @kgryte @anandkaranubc
feat: add array/base/reshape
e9cd399 
PR-URL: stdlib-js#5639
Closes: stdlib-js/metr-issue-tracker#20
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Muhammad Haris <harriskhan047@outlook.com>
Signed-off-by: Athan Reines <kgryte@gmail.com>
@headlessNode headlessNode deleted the array-base-reshape branch April 9, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add array/base/reshape

3 participants

@headlessNode @stdlib-bot @kgryte