Skip to content

refactor!: update math/base/special/cabs2f to follow latest project conventions #4767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 18, 2025
Merged

refactor!: update math/base/special/cabs2f to follow latest project conventions #4767

merged 14 commits into from
Apr 18, 2025

Conversation

@vivekmaurya001
Copy link
Contributor

@vivekmaurya001 vivekmaurya001 commented Jan 15, 2025

Description

  • refactors C implementation for @stdlib/math/base/special/cabs2f along with relevant tests, benchmarks and examples to follow latest conventions
  • added test.native.js, benchmark.native.js, addon file , native.js
  • updated the readme file , package.json , benchmark.c , examples.c
  • updated the initial test file to use absf instead of abs

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

vivekmaurya001 and others added 6 commits January 15, 2025 11:06
@vivekmaurya001
feat(add c implementation): add math/base/special/cabs2f
0895ff9 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: passed
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: failed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: passed
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: failed
---
@vivekmaurya001
feat(add c implementation): add math/base/special/cabs2f
97cc4ae
@vivekmaurya001
Merge branch 'stdlib-js:develop' into math/cabs2f
18bd3a6
@vivekmaurya001
Merge branch 'stdlib-js:develop' into math/cabs2f
ded25e7
@vivekmaurya001
feat(add c implementation): add math/base/special/cabs2f
1954bd5 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@vivekmaurya001
feat(add c implementation): add math/base/special/cabs2f
dadf055 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@vivekmaurya001 vivekmaurya001 marked this pull request as draft January 15, 2025 17:14
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Jan 15, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 15, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/special/cabs2f $\color{green}143/143$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}143/143$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@vivekmaurya001
Copy link
Contributor Author

vivekmaurya001 commented Jan 15, 2025

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 15, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 15, 2025
@vivekmaurya001 vivekmaurya001 marked this pull request as ready for review January 15, 2025 17:23
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 15, 2025
@vivekmaurya001
Copy link
Contributor Author

vivekmaurya001 commented Jan 15, 2025

good evening @gunjjoshi , please give this a review

@gunjjoshi gunjjoshi self-requested a review January 16, 2025 01:06
@kgryte kgryte mentioned this pull request Mar 12, 2025
Closed
1 task
@anandkaranubc anandkaranubc self-requested a review April 15, 2025 06:10
@anandkaranubc anandkaranubc changed the title refactor: update c implementation for math/base/special/cabs2f refactor: update math/base/special/cabs2f to follow latest project conventions Apr 15, 2025
@anandkaranubc
Copy link
Contributor

anandkaranubc commented Apr 15, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 15, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 15, 2025
@anandkaranubc
chore: fix use of negative spaces
9a401b1 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
docs: re-enable lint rule
d474e2b 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
docs: fix example inputs
508c857 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
bench: fix use of negative spaces
59506ac 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
anandkaranubc
anandkaranubc previously approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@anandkaranubc anandkaranubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@anandkaranubc anandkaranubc requested a review from kgryte April 15, 2025 06:49
anandkaranubc
anandkaranubc reviewed Apr 15, 2025
View reviewed changes
@anandkaranubc
Update lib/node_modules/@stdlib/math/base/special/cabs2f/README.md
1c2dfe4 
Signed-off-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com>
@anandkaranubc
Update lib/node_modules/@stdlib/math/base/special/cabs2f/examples/c/e…
ecf089f 
…xample.c

Signed-off-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com>
@anandkaranubc anandkaranubc mentioned this pull request Apr 15, 2025
Merged
1 task
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 18, 2025
@kgryte kgryte changed the title refactor: update math/base/special/cabs2f to follow latest project conventions refactor!: update math/base/special/cabs2f to follow latest project conventions Apr 18, 2025
@kgryte kgryte added the release: Major Breaking change requiring a new major release. label Apr 18, 2025
@kgryte kgryte merged commit d89509f into stdlib-js:develop Apr 18, 2025
31 checks passed
@anandkaranubc anandkaranubc mentioned this pull request May 19, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

@anandkaranubc anandkaranubc anandkaranubc approved these changes

@gunjjoshi gunjjoshi Awaiting requested review from gunjjoshi

Assignees

No one assigned

Labels

Math Issue or pull request specific to math functionality. release: Major Breaking change requiring a new major release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vivekmaurya001 @stdlib-bot @anandkaranubc @kgryte