-
Notifications
You must be signed in to change notification settings - Fork 148
proxy: c-frontend #3745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chirag-parmar
wants to merge
16
commits into
master
Choose a base branch
from
c-frontend
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
proxy: c-frontend #3745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nimbus verified proxy CI / linux-amd64 (pull_request) is due to: |
1d729af to
917f68a
Compare
8aa9a38 to
7c0bb47
Compare
29d990c to
0937573
Compare
39a0667 to
94badb4
Compare
ea641f0 to
2645012
Compare
a91631d to
d277ef9
Compare
92587c3 to
bc09ffb
Compare
db804f3 to
5bdcd87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a C frontend for the verified proxy so that it can be used as a static library
Notes and Pointers for discussion:
chronosis exported in a single threaded manner (processVerifProxyTasks) and must be called (orpolled) regularly for efficient processing of the underlying async tasks. This means any busy waiting in the main loop of the application is forbidden (which is the case independent of this PR). This is a deliberate choice, since it is easier to develop multi-threaded logic in other languages/frameworks(ex: Go and Rust) where this library would be used rather than ship the library with the async event loop running on a different thread.processVerifProxyTasks), any other async tasks dispatched independently will not be polled.nimbus_verified_proxy.nimis abstracted/refactored out to be reused for the C frontend (verifproxy.nim). The PR also removes thestopprocs from theLightClientto allow the C frontend to manually cancel the future associated with it.nimbus_verified_proxy/libverifproxy/example.c, the instructions for compiling are added to theREADMEwithin that directory.Meta: #3101
Experimentation: chirag-parmar/nim-playground@a877be0