Skip to content

Add test covering HashKey rlp encoding when data contains embedded trie node #3578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 27, 2025
Merged

Add test covering HashKey rlp encoding when data contains embedded trie node #3578

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8592802
Fix rlp encoding of HashKey type.
bhartnett Aug 22, 2025
6d9e0d4
Merge branch 'master' into fix-hashkey-rlp-encoding
bhartnett Aug 27, 2025
dc20527
Add test which covers trie root calculations for embedded trie node i…
bhartnett Aug 27, 2025
b254482
Revert change to Hashkey type.
bhartnett Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion execution_chain/db/aristo/aristo_desc/desc_identifiers.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ func hash*(a: HashKey): Hash =

func append*(w: var RlpWriter; key: HashKey) =
if 1 < key.len and key.len < 32:
w.appendRawBytes key.data
Copy link
Contributor Author

@bhartnett bhartnett Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chirag-parmar Do you know of any reason why this might be encoding values as a list rather than a blob?

Copy link
Contributor Author

@bhartnett bhartnett Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the code that decodes the trie nodes and expects a blob to be present in each of the branch node indexes, not a list:

nimbus-eth1/execution_chain/db/aristo/aristo_proof.nim

Line 243 in d584afb

link = rlpNode.listElem(path[0].int).toBytes

Copy link
Contributor

@chirag-parmar chirag-parmar Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird.

All I can say is that HashKey is being encoded as a list because the overloading resolution algorithm at the time of compilation uses the generic method defined here https://github.com/status-im/nim-eth/blob/master/eth/rlp/writer.nim#L202 for serializing it. At the time of compilation, for some unknown reason, it doesn't mixin the append method defined in desc_identifiers.nim.

I have been facing a similar issue #3572. Even here, the score gets serialized as a list (because it is an object: UInt256) UNLESS I include that one magical line of code.

So I think the change you made has nothing to do with the incorrect serialization. This is just my educated guess (even writeBlob calls appendRawBytes internally)

Copy link
Contributor Author

@bhartnett bhartnett Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird.

All I can say is that HashKey is being encoded as a list because the overloading resolution algorithm at the time of compilation uses the generic method defined here https://github.com/status-im/nim-eth/blob/master/eth/rlp/writer.nim#L202 for serializing it. At the time of compilation, for some unknown reason, it doesn't mixin the append method defined in desc_identifiers.nim.

I have been facing a similar issue #3572. Even here, the score gets serialized as a list (because it is an object: UInt256) UNLESS I include that one magical line of code.

So I think the change you made has nothing to do with the incorrect serialization. This is just my educated guess (even writeBlob calls appendRawBytes internally)

I see, well thanks for the info. I'll keep looking into it as it would be good to know definitively the root cause.

w.writeBlob key.data
else:
w.append key.data

Expand Down
Loading