Enhance StreamListener to support generic type annotations for output #9112
+28
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fields - Added import of inspect to facilitate type checking. - Updated the condition for handling custom streamable types to include a check for class type using inspect.isclass. - Introduced a new test for StreamListener to validate behavior with generic type annotations in output fields. Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
chenmoneygithub
approved these changes
Dec 4, 2025
Collaborator
chenmoneygithub
left a comment
chenmoneygithub
left a comment
There was a problem hiding this comment.
The fix LGTM, one comment on the test case. Feel free to merge after addressing it!
| ) | ||
|
|
||
| with dspy.context(adapter=dspy.JSONAdapter()): | ||
| result = listener.receive(mock_chunk) |
Collaborator
There was a problem hiding this comment.
I do get what the test case is testing, but our future maintainers could be confused. Maybe add a few more chunks + flush to make the test easier to follow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9099