Skip to content

Conversation

@g0rgamesh
Copy link
Contributor

@g0rgamesh g0rgamesh commented Nov 27, 2025

After permission fix the filebeat service is still stopped, it needs to be restarted.

@g0rgamesh g0rgamesh requested a review from a team as a code owner November 27, 2025 10:54
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a handler to restart the filebeat service when the permissions of its alert manifest file are changed. The change is logical and improves the robustness of the configuration. I've suggested one improvement to use a variable for the service name in the new handler, which aligns with best practices for Ansible roles and improves maintainability.

@priteau
Copy link
Member

priteau commented Nov 27, 2025

s/compliment/complement/ 😉

@g0rgamesh g0rgamesh changed the title add filbeat restart to compliment the go-w on manifest.yml add filbeat restart to complement the go-w on manifest.yml Nov 27, 2025
@priteau
Copy link
Member

priteau commented Nov 28, 2025

s/compliment/complement/ 😉

Can you update the commit message with git commit --amend to fix the typo? Use this opportunity to rebase instead of merging the 2025.1 branch which is messy.

@g0rgamesh
Copy link
Contributor Author

s/compliment/complement/ 😉

Can you update the commit message with git commit --amend to fix the typo? Use this opportunity to rebase instead of merging the 2025.1 branch which is messy.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants