Update JavaDocs for grpc-client classes #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
CI failure probably means you need to fix something. Please squash and rebase before you push. |
therepanic
force-pushed
the
update-JavaDocs-for-grpc-client-classes
branch
from
4d037dc to
e50de76
Compare
Member
|
Still failing. Please run |
therepanic
force-pushed
the
update-JavaDocs-for-grpc-client-classes
branch
from
e50de76 to
b442020
Compare
Contributor
Author
|
I think everything should be okay now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will be good for us, since java-doc has already been described for grpc-server classes, so I guess it's worth doing the same for grpc-client classes