Add autoconfig for reflection service and friends #26 #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…spring-projects#26 Signed-off-by: CyberZujo <hara_zujo@hotmail.com>
dsyer
reviewed
Nov 4, 2024
onobc
requested changes
Nov 5, 2024
Contributor
onobc
left a comment
onobc
left a comment
There was a problem hiding this comment.
Thanks for the contribution @CyberZujo . I have a added a few comments/suggestions. It is close to ready though.
...ava/org/springframework/grpc/autoconfigure/server/GrpcServerReflectionAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...ava/org/springframework/grpc/autoconfigure/server/GrpcServerReflectionAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...rg/springframework/grpc/autoconfigure/server/GrpcServerReflectionAutoConfigurationTests.java
Show resolved
Hide resolved
...ava/org/springframework/grpc/autoconfigure/server/GrpcServerReflectionAutoConfiguration.java
Outdated
Show resolved
Hide resolved
…framework/grpc/autoconfigure/server/GrpcServerReflectionAutoConfiguration.java Co-authored-by: Chris Bono <chris.bono@gmail.com>
vuhp
reviewed
Nov 7, 2024
...ava/org/springframework/grpc/autoconfigure/server/GrpcServerReflectionAutoConfiguration.java
Outdated
Show resolved
Hide resolved
Signed-off-by: CyberZujo <hara_zujo@hotmail.com>
…n update spring-projects#26 Signed-off-by: CyberZujo <hara_zujo@hotmail.com>
Signed-off-by: CyberZujo <hara_zujo@hotmail.com>
Contributor
Author
|
@onobc Updated the PR, please check! Thanks! |
dsyer
reviewed
Nov 9, 2024
...ava/org/springframework/grpc/autoconfigure/server/GrpcServerReflectionAutoConfiguration.java
Outdated
Show resolved
Hide resolved
Member
|
Merged in d61af1a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… - Add autoconfig for reflection service and friends #26