Skip to content

Conversation

@cppwfs
Copy link
Contributor

@cppwfs cppwfs commented Dec 3, 2025

Clarify that the launched.grpc.port environment variable must be set to specify the server port, rather than assuming port 9090. Add concrete example of setting the environment variable using export command.

Clarify that the `launched.grpc.port` environment variable must be
set to specify the server port, rather than assuming port 9090. Add
concrete example of setting the environment variable using export
command.
@onobc
Copy link
Contributor

onobc commented Dec 3, 2025

Thanks @cppwfs for this great catch.

So these samples are also serve as our integration tests.
We use Spring Boot testjars to launch the server used by the apps that are the target of the tests.
Those tests set the launched.grpc.port via testjars @DynamicProperty(name = "launched.grpc.port", value = "port") in the tests (see org.springframework.grpc.sample.GrpcClientApplicationTests.ExtraConfiguration#grpcServer).
When we made this change to launched.grpc.port, we forgot to think about just running it by hand (not via tests).

I modified your change to use a default port in the sPEL thus allowing the user to set the port only when its not 9090. PTAL.

Closing this in favor of b89ecd2

@onobc onobc closed this Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants