Missing important issue about micrometer annotations

[michaldo]

Class org.aspectj.weaver.Advice is required

[philwebb]

Thanks for the suggestion, but I don't think we want to make such a strong recommendation. Setting management.observations.annotations.enabled to true and using AspectJ will auto-configure Micrometer aspects, but these annotations are also useful for users not using AspectJ. I think we'll use #48259 to update the migration guide wiki instead.

[midovlvn]

@philwebb maybe my change is too strong recommendation, but there must be mentioned that setting management.observations.annotations.enabled to true is not enough

[philwebb]

Fair point, I've added a note to #48259 to also add something to the docs.

[michaldo]

Maybe it is not documentation issue, but class org.aspectj.weaver.Advice should be in dependencies of spring-boot-starter-micrometer-metrics?

[wilkinsona]

No, we don't think so. That's too strong an opinion as there are many way in which Micrometer Metrics is useful without AspectJ. That includes the annotations as, for example, @Timed can be used on a Spring Data Repository without requiring AspectJ.