Refactor the JpaPagingItemReader by making the entityManagerFactory f…

spring-batch-infrastructure/src/main/java/org/springframework/batch/infrastructure/item/database/JpaItemWriter.java

@@ -49,7 +49,7 @@ public class JpaItemWriter<T> implements ItemWriter<T> {
 
 	protected static final Log logger = LogFactory.getLog(JpaItemWriter.class);
 
-	private EntityManagerFactory entityManagerFactory;
+	private final EntityManagerFactory entityManagerFactory;
 
 	private boolean usePersist = false;
 
@@ -65,14 +65,6 @@ public JpaItemWriter(EntityManagerFactory entityManagerFactory) {
 		this.entityManagerFactory = entityManagerFactory;
 	}
 
-	/**
-	 * Set the EntityManager to be used internally.
-	 * @param entityManagerFactory the entityManagerFactory to set
-	 */
-	public void setEntityManagerFactory(EntityManagerFactory entityManagerFactory) {
-		this.entityManagerFactory = entityManagerFactory;
-	}
-
 	/**
 	 * Set whether the EntityManager should perform a persist instead of a merge.
 	 * @param usePersist whether to use persist instead of merge.

spring-batch-infrastructure/src/main/java/org/springframework/batch/infrastructure/item/database/JpaPagingItemReader.java

@@ -87,7 +87,7 @@
  */
 public class JpaPagingItemReader<T> extends AbstractPagingItemReader<T> {
 
-	private EntityManagerFactory entityManagerFactory;
+	private final EntityManagerFactory entityManagerFactory;
 
 	private @Nullable EntityManager entityManager;
 
@@ -113,10 +113,6 @@ public JpaPagingItemReader(EntityManagerFactory entityManagerFactory) {
 		this.entityManagerFactory = entityManagerFactory;
 	}
 
-	public void setEntityManagerFactory(EntityManagerFactory entityManagerFactory) {
-		this.entityManagerFactory = entityManagerFactory;
-	}
-
 	/**
 	 * The parameter values to be used for the query execution.
 	 * @param parameterValues the values keyed by the parameter named used in the query

spring-batch-infrastructure/src/test/java/org/springframework/batch/infrastructure/item/database/JpaPagingItemReaderNamedQueryIntegrationTests.java

@@ -47,7 +47,6 @@ protected AbstractPagingItemReader<Foo> getItemReader() throws Exception {
 		jpaNamedQueryProvider.setEntityClass(Foo.class);
 		jpaNamedQueryProvider.afterPropertiesSet();
 
-		reader.setEntityManagerFactory(entityManagerFactory);
 		reader.setQueryProvider(jpaNamedQueryProvider);
 		reader.afterPropertiesSet();
 		reader.setSaveState(true);