Fix retryLimit() to exclude Error types by default #5082
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5078
Summary
When
retryLimit()is called without explicitretry()configuration, fault-tolerant steps now default to retryingExceptiontypes only, excluding fatal JVMErrortypes likeOutOfMemoryErrorandStackOverflowError.Problem
Previously, using
retryLimit(N)withoutretry(...)would retry allThrowabletypes, including fatal JVM errors that should fail immediately.Example of problematic code:
Solution
Modified
ChunkOrientedStepBuilder.build()to default toSet.of(Exception.class)whenretryableExceptionsis empty, preserving explicitretry()configurations for backward compatibility.After the fix:
Changes
Modified
ChunkOrientedStepBuilder.java: Added JavaDoc and default Exception.class logic (+16, -4 lines)Added
ChunkOrientedStepBuilderTests.java: 3 unit tests verifying the fix and backward compatibilityTests
Backward Compatibility
✅ 100% backward compatible - explicit
retry()configurations work exactly as before