Fix default skip policy when only retry is configured #5080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When retry is configured without explicit skip settings, the default SkipPolicy should be NeverSkipItemSkipPolicy instead of AlwaysSkipItemSkipPolicy to prevent silent data loss when items fail after retry exhaustion. This commit removes the `skipLimit > 0` condition from the skip policy initialization, ensuring NeverSkipItemSkipPolicy is used when no skip exceptions are explicitly configured via the skip() method. Resolves spring-projectsgh-5077 Signed-off-by: kjg <kimjg2477@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix default skip policy when only retry is configured.
When configuring retry without skip in a fault-tolerant step, items that
fail after exhausting retry attempts are currently silently skipped instead
of failing the step, which can lead to silent data loss.
This PR changes the default SkipPolicy from AlwaysSkipItemSkipPolicy to
NeverSkipItemSkipPolicy when no skip exceptions are explicitly configured.
Changes:
skipLimit > 0condition from skip policy initializationResolves gh-5077