Skip to content

GH-4755: Fix wrong behavior of JobRepository with empty identifying job parameters #4946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

GH-4755: Fix wrong behavior of JobRepository with empty identifying job parameters #4946

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .../src/main/java/org/springframework/batch/core/launch/support/TaskExecutorJobLauncher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
* @author Will Schipp
* @author Michael Minella
* @author Mahmoud Ben Hassine
* @author Seungyong Hong
* @since 1.0
* @see JobRepository
* @see TaskExecutor
Expand Down Expand Up @@ -144,8 +145,7 @@ private JobExecution createJobExecution(Job job, JobParameters jobParameters)
JobParameters allJobParameters = execution.getJobParameters();
JobParameters identifyingJobParameters = new JobParameters(
allJobParameters.getIdentifyingParameters());
if (!identifyingJobParameters.isEmpty()
&& (status == BatchStatus.COMPLETED || status == BatchStatus.ABANDONED)) {
if (status == BatchStatus.COMPLETED || status == BatchStatus.ABANDONED) {
throw new JobInstanceAlreadyCompleteException(
"A job instance already exists and is complete for identifying parameters="
+ identifyingJobParameters + ". If you want to run this job again, "
Expand Down