Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -345,12 +345,16 @@ private Flux<ChatResponse> internalStream(Prompt prompt, ChatResponse previousCh
.toolCalls(toolCalls)
.build();

ChatGenerationMetadata generationMetadata = ChatGenerationMetadata.NULL;
ChatGenerationMetadata.Builder generationMetadataBuilder = ChatGenerationMetadata.builder();
if (chunk.promptEvalCount() != null && chunk.evalCount() != null) {
generationMetadata = ChatGenerationMetadata.builder().finishReason(chunk.doneReason()).build();
generationMetadataBuilder.finishReason(chunk.doneReason());
}

var generator = new Generation(assistantMessage, generationMetadata);
if (chunk.message() != null && chunk.message().thinking() != null) {
generationMetadataBuilder.metadata("thinking", chunk.message().thinking());
}

var generator = new Generation(assistantMessage, generationMetadataBuilder.build());
return new ChatResponse(List.of(generator), from(chunk, previousChatResponse));
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,12 @@

package org.springframework.ai.ollama;

import java.util.concurrent.atomic.AtomicBoolean;

import io.micrometer.observation.tck.TestObservationRegistry;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import reactor.core.publisher.Flux;

import org.springframework.ai.chat.metadata.ChatGenerationMetadata;
import org.springframework.ai.chat.model.ChatResponse;
Expand Down Expand Up @@ -70,6 +73,60 @@ void ollamaThinkingMetadataCaptured() {
});
}

@Test
void ollamaThinkingMedataCapturedWhenStreaming() {
var options = OllamaChatOptions.builder().model(MODEL).enableThinking().build();
var response = new StringBuilder();
var thinking = new StringBuilder();
var foundThinking = new AtomicBoolean(false);

Prompt prompt = new Prompt("Why is the sky blue?", options);

Flux<ChatResponse> chatResponse = this.chatModel.stream(prompt);
var captured = chatResponse.collectList().block();

assertThat(captured).isNotEmpty();

captured.forEach(chunk -> {
ChatGenerationMetadata chatGenerationMetadata = chunk.getResult().getMetadata();
assertThat(chatGenerationMetadata).isNotNull();

if (chatGenerationMetadata.containsKey("thinking") && chatGenerationMetadata.get("thinking") != null) {
foundThinking.set(true);
thinking.append(chatGenerationMetadata.get("thinking").toString());
}

response.append(chunk.getResult().getOutput().getText());
});

assertThat(response.toString()).isNotEmpty();
assertThat(thinking.toString()).isNotEmpty();
}

@Test
void ollamaThinkingMedataNotCapturedWhenStreamingWhenSetThinkingToFalse() {
var options = OllamaChatOptions.builder().model(MODEL).disableThinking().build();
var response = new StringBuilder();

Prompt prompt = new Prompt("Why is the sky blue?", options);

Flux<ChatResponse> chatResponse = this.chatModel.stream(prompt);
var captured = chatResponse.collectList().block();

assertThat(captured).isNotEmpty();

captured.forEach(chunk -> {
ChatGenerationMetadata chatGenerationMetadata = chunk.getResult().getMetadata();
assertThat(chatGenerationMetadata).isNotNull();
var thinking = chatGenerationMetadata.get("thinking");
assertThat(thinking).isNull();

response.append(chunk.getResult().getOutput().getText());
});

assertThat(response.toString()).isNotEmpty();
}

@Test
void ollamaThinkingMetadataNotCapturedWhenSetThinkFlagToFalse() {
// Note: Thinking-capable models (e.g., qwen3:*) auto-enable thinking by default
Expand Down